Patch for D9 readiness

attached screenshot came from running the following command:

/vendor/bin/phpstan analyse --memory-limit=512M --error-format=json -c /tmp/upgrade_status/deprecation_testing.neon /var/www/html/public/modules/contrib/select2boxes 2> /
tmp/upgrade_status/phpstan_error_output

Fixed by replacing the test class from JavascriptTestBase to WebDriverTestBase

Also went ahead and added the *info.yml D8 || D9 readiness

CommentFileSizeAuthor
#6 d9-readiness-3199366-6.patch1.23 KBrjensen26
#5 d9-readiness-3199366-5.patch1.19 KBrjensen26
#4 d9-readiness-3199366-4.patch1.19 KBrjensen26
#3 d9-readiness-3199366-3.patch1.14 KBrjensen26
#2 d9-readiness-3199366-2.patch1.14 KBrjensen26
Screen Shot 2021-02-19 at 12.33.06 PM.png129.25 KBrjensen26

Comments

rjensen26 created an issue. See original summary.

rjensen26’s picture

rjensen26 commented
StatusFileSize
new d9-readiness-3199366-2.patch1.14 KB

Adding patch

rjensen26’s picture

rjensen26 commented
StatusFileSize
new d9-readiness-3199366-3.patch1.14 KB

patch for 1.0.0-alpha4

rjensen26’s picture

rjensen26 commented
StatusFileSize
new d9-readiness-3199366-4.patch1.19 KB

Patch #3 does not apply working re-roll

rjensen26’s picture

rjensen26 commented
StatusFileSize
new d9-readiness-3199366-5.patch1.19 KB

Patch #4 returns 

Unable to parse modules/contrib/select2boxes/select2boxes.info.yml Duplicate key "configure" detected at line 9 (near "configure: select2boxes.conf  
  ig_form").

error

rjensen26’s picture

rjensen26 commented
StatusFileSize
new d9-readiness-3199366-6.patch1.23 KB

Fixing an issue from #5

tjtj’s picture

tjtj commented

This patched Select2 Boxes but not Select2 Better Exposed Filters
Please install the patches into as release version.

matsbla’s picture

matsbla commented
Status: Needs review » Closed (duplicate)
Related issues: +#3101228: Add new key core_version_requirement in select2boxes.info.yml, +#3056163: Replace deprecated JavascriptTestBase

Thank you for opening the issue :)
We already have two issues open, one for updateing the tests, and another to declear the project D9 ready, please add your efforts into the exiting issues!