Ever since I installed version 6.x-1.1 of the security_review module, I get the following error:

Invalid argument supplied for foreach() in /my_site/public_html/modules/security_review/security_review.checks.inc on line 378.

The failed logins page doesn't display the URLs.
page: /admin/reports/security-review/help/security_review/failed_logins

Code lines 378-381 are:
foreach ($results['value'] as $ip) {
$element['findings']['items'][] = array(
'safe' => check_plain($ip),
'raw' => $ip,

In addition, there is a blank line that displays between the lines: Dangerous tags were not found in any comments. and Error reporting set to log only.
After running security review, it does display a green check.

Any help would be appreciated.

(Someone in the modules forum suggested I post this here...could be a bug?)

Thanks much,
Denise

Comments

coltrane’s picture

When you upgraded from 1.0 did you uninstall the module first? If not, try that now. You need to uninstall and then reinstall to correct the blank line. Go to Admin > Build > Modules, uncheck Security Review and save. Then visit the Uninstall tab and uninstall Security Review. Once complete go back to the module list and reenable the module.

denise_silv’s picture

That works. Thank you! Being a DIY drupal site developer, I had no idea I had to do that. Now I know. :D

coltrane’s picture

Note, that's only needed for the 1.1 release, it's rarely correct to do so for other modules.

greggles’s picture

Category: bug » support
Status: Active » Fixed

Glad to hear this is fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.