Make placeholder and title properties configurable in SearchBlock

For future reference: an issue gets set to "needs review" after you have created a patch file.

Also, at this point, feature requests are Drupal 8 material. It is past the deadline for Drupal 7.

But I actually don't think we would consider this idea for Drupal core. It's easily accomplished with hook_form_alter() in a contributed module, and we don't use this pattern in other Drupal forms.

With regards for this particular code:
- If it were to be added to Drupal core, the default text would need to be something other than "Search me".
- The default would need to be enclosed in the t() function.
- Form element titles do not end in ":"
- We try not to abbreviate variables. So it should be 'search_teaser_string' not 'str'.
- Also, the word "teaser" has a different meaning in Drupal. So it should be renamed as something else, not teaser.
- We don't add "OnClick" directly to forms, but via standard Drupal JavaScript methods.

I'm not sure where you read that. t() is alive and well in Drupal 7. There are a few spots where certain hooks ask you to put non-translated information, and it's automatically passed through t() for you, but t() is most certainly still the translation function.

If you would like some evidence:
http://api.drupal.org/api/function/t/7

Scroll down to the bottom and you'll see there are over 1000 calls to t() just in the Drupal core code base. :)

I think this might be a common enough need that it's worth reopening. (Try searching the internet for "drupal search placeholder" and you can see there are tons of people trying to do this.)

It can be done with a form_alter, but that is not super-clean and it it seems like this is something a site administrator might want to configure. Also, there is now an installation profile in core which adds this text too (see #2937636: Umami Theme - follow-up - Use hook_form_alter() for search block placeholder).

These days, we'd do this with a placeholder attribute (not JavaScript), which is one reason I marked this for an issue summary update. The current search block has a hardcoded title attribute ("Enter the terms you wish to search for") but no placeholder attribute.

This could probably actually be made configurable on the block configuration form itself.

Is this issue still in need or deprecated in favor of another attempt/solution? I think not configurable placeholders is still a missing configuration option especially for multilingual sites. Let me know if I miss something or of we should gain forces here. Set it to Needs review to gain temp. attention for the question. Feel free to set it back to Active or to Needs work or something else regarding the way it should go and if you can give some thoughts on it. Thanks!

The current search block has a hardcoded title attribute ("Enter the terms you wish to search for") but no placeholder attribute.

This could probably actually be made configurable on the block configuration form itself

Seems like the path forward that would need to happen

Will need test coverage as well when implemented.

Attached MR adds the option of configuring the title and placeholder HTML properties for search block forms.

A new test is included and as many dependents as I noticed (umami, olivero, help) have been updated.

Also: I'm not entirely sure if passing the configuration to getForm is the cleanest thing but I also couldn't see an obvious reason to frown upon it, since page_id is already being passed.

I'm a little confused about how/where to set a fallback default, I simply chose a place and ran with it. Hopefully I wasn't _that_ far off.

Believe issue summary still needs to be updated, recommend using standard issue template.

New configuration will require an upgrade path for existing sites. Also a change record.

For the new changes probably will need usability team to take a look

Thanks

Updated summary and removed corresponding tag.

How would I go about getting the usability team's review on this?

The Search Module was approved for removal in #3476883: [Policy, no patch] Move Search module to contrib .

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3565780: [meta] Tasks to deprecate the Search module and the removal work in #3565783: [meta] Tasks to remove the Search module.

Search will be moved to a contributed project before Drupal 12.0.0 is released.

The Search Module has moved from core to contrib,