Module is using drupal_set_message function to display messages which was deprecated and will be no longer working in Drupal 9 which is planned to be released in June 2020.

CommentFileSizeAuthor
#10 scmsg_noerrors.PNG4.38 KBagrochal
#10 3099387-10.patch880 bytesagrochal
#9 scmsg_errors.PNG15.64 KBagrochal
#5 3099387-5.patch2.06 KBagrochal
#2 3099387-2.patch912 bytesagrochal

Comments

agrochal created an issue. See original summary.

agrochal’s picture

agrochal commented
StatusFileSize
new 3099387-2.patch912 bytes

I've actually removed deprecated code and replaced it with Messenger service. I attach .patch file.

agrochal’s picture

agrochal commented
Status: Active » Needs review
agrochal’s picture

agrochal commented
Status: Needs review » Needs work

I’ll replace messenger service into dependency injection.

agrochal’s picture

agrochal commented
StatusFileSize
new 3099387-5.patch2.06 KB

Okay, I've created the patch which replaces drupal_set_message with messenger service which is added in dependency injection.

agrochal’s picture

agrochal commented
Status: Needs work » Needs review
maliknaik’s picture

maliknaik commented

@agrochal, ConfigFormBase uses MessengerTrait, so you can directly use $this->messenger()->addMessage(), and there is no need for Dependency injection here.

https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21ConfigFormBase.php/class/ConfigFormBase/8.8.x

maliknaik’s picture

maliknaik commented
Status: Needs review » Needs work
agrochal’s picture

agrochal commented
Issue summary: View changes
StatusFileSize
new scmsg_errors.PNG15.64 KB
agrochal’s picture

agrochal commented
StatusFileSize
new 3099387-10.patch880 bytes
new scmsg_noerrors.PNG4.38 KB

Okay, here's new patch.

agrochal’s picture

agrochal commented
Status: Needs work » Needs review
maliknaik’s picture

maliknaik commented
Status: Needs review » Reviewed & tested by the community

The patch in #10 looks fine.

Drupal check result before applying the patch:

[2K 2/2 [============================] 100%

 ------ ----------------------------------------------------------------------
  Line   src\Form\SimpleCoolMessage.php
 ------ ----------------------------------------------------------------------
  118    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 [ERROR] Found 1 error

Drupal check result after applying the patch:

[2K 2/2 [============================] 100%

 [OK] No errors