This module needs a bit of love when it comes to coding standards, http://drupal.org/coding-standards. The biggest problems are inline control structures and missing function doc comments.

I found some time to run trough the main module file and apply coding standards for all active code. I will post this in the next few minutes.

CommentFileSizeAuthor
#4 patch-applied.png53.28 KBhimanshu_jhaloya
#1 sc_basic-apply_coding_standards-1879694-1.patch26.31 KBericmulder1980

Issue fork sc_basic-1879694

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ericmulder1980’s picture

ericmulder1980 CreditAttribution: ericmulder1980 commented
Status: Active » Needs review
FileSize
sc_basic-apply_coding_standards-1879694-1.patch26.31 KB

Et voila, the patch to solve this issue.

himanshu_jhaloya made their first commit to this issue’s fork.

himanshu_jhaloya’s picture

himanshu_jhaloya CreditAttribution: himanshu_jhaloya at Valuebound for Valuebound commented
Assigned: Unassigned » himanshu_jhaloya
Issue summary: View changes

I will review the patch

himanshu_jhaloya’s picture

himanshu_jhaloya CreditAttribution: himanshu_jhaloya at Valuebound for Valuebound commented
Assigned: himanshu_jhaloya » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
patch-applied.png53.28 KB

Patch applied cleanly, No error found