I love what you have done so far, I have pretty much done all this for an in-house module that extends the version 6 short code, but i did it more like the shortcode_basic_tags module.

I notice you do not return your output via a theme, is there any reason you have chosen this method?

Comments

jurriaanroelofs’s picture

jurriaanroelofs commented

since this module is basicall a "styles" package I consider it to be at the same level as themes. This module outputs HTML that is tightly coupled to its own css and images so if you override it things will probably break. No theme functions also means less code and thus easier maintainability and faster performance.

If a lot of people disagree with this choice I can always convert it to use theme functions.