Problem/Motivation

If a pre-custom text has some special HTML code inside, a free space or something similar, it's difficult to detect. We get an empty paragraph at that point.

Proposed resolution

The easier solution is to add a class (something like "salsa-pre-custom-text") to pre-custom text and hide it with CSS.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#3 add_class_to_pre_custom-2486741-3-interdiff.txt804 bytessasanikolic
#3 add_class_to_pre_custom-2486741-3.patch1005 bytessasanikolic
#2 add_class_to_pre_custom-2486741-2.patch987 bytessasanikolic

Comments

sasanikolic’s picture

sasanikolic commented
Issue summary: View changes
sasanikolic’s picture

sasanikolic commented
Status: Active » Needs review
StatusFileSize
new add_class_to_pre_custom-2486741-2.patch987 bytes
sasanikolic’s picture

sasanikolic commented
StatusFileSize
new add_class_to_pre_custom-2486741-3.patch1005 bytes
new add_class_to_pre_custom-2486741-3-interdiff.txt804 bytes

Changed the name of the class.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed.

  • Berdir committed de56095 on 7.x-1.x authored by sasanikolic 
    Issue #2486741 by sasanikolic: Add class to pre-custom text

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.