Closed (fixed)
Project:
Rules
Version:
7.x-2.x-dev
Component:
Rules Engine
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Aug 2010 at 16:12 UTC
Updated:
3 Sep 2010 at 04:40 UTC
Jump to comment: Most recent file
This is the patch for rules_optimization module rule sets integration.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | rules_optimization_integration_2.patch | 3.39 KB | Saubhagya |
| #2 | rules_optimization_integration-2.patch | 1.46 KB | Saubhagya |
| rules_optimization_integration-2.patch | 1.32 KB | Saubhagya |
Comments
Comment #1
klausiRule set related code should go to the Rule set class, not to the generic plugin class.
Comment #2
Saubhagya commentedYes, I moved the code to rule sets.
Comment #3
fagoI think if we add that, we should add it generically for all components - thus in the parent implementation.
However optimizing rule sets will be hard, as the execution order is important there. Let's make sure it's working fine for event sets first. Anyway, let's add this in asap.
Comment #4
Saubhagya commentedComment #5
klausinow the comment does not belong to this line. A separate comment for optimize() would be nice.
What about event sets? Do we leave the second optimize() call there because we create a new one?
This is a lot of duplicate code. I think it would be better to use an info_alter hook to add the optimization extender to all components.
Powered by Dreditor.
Comment #6
fagoI improved how optimizers are integrated so we don't need the empty default extender + components are generically supported (not only rule sets). Please test and report whether it works as it should ;)
Comment #7
Pranshu commentedComment #8
klausiwhy? this issue is resolved?
Comment #9
Pranshu commentedsorry about that..I'm kinda newbie here, didn't intended this to happen !