Sometime in the past few weeks there have been some big changes made to the GitLab CI phpcs configurations, with the result that we are now seeing dozens of phpcs warnings and errors for things that it didn't used to complain about. And there have been other changes, like the definition of what constitutes "alphabetical order" has changed in the past few weeks, so that "use" statements that were in alphabetical order a few weeks ago are no longer considered to be in alphabetical order anymore.

There have been no change records or other notifications about these changes.

This issue is so I can have a place to work on solving some of these things.

Now a meta issue - each of the problems that have been identified will get its own issue.

Issue fork rules-3479263

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tr created an issue. See original summary.

tr opened merge request !76

tr’s picture

tr commented
Title: Address new phpstan issues » Address new phpcs issues
Issue summary: View changes
tr’s picture

tr commented

Use statements were fixed in #3494028: Re-sort use statements using the new alphabetical ordering

tr’s picture

tr commented
Title: Address new phpcs issues » [meta] Address new phpcs issues
Issue summary: View changes

The MR fixes everything, but it mixes up a lot of different issues and some fixes unrelated to phpcs (but discovered by phpcs) are mixed in here.

So I'm turning this into a meta issue so that the fixes are a lot more narrow - I find that helps greatly when looking at old code and trying to figure out why things were done.

So ignore the MR - all these changes will be moved into other issues and committed one by one.

ggh made their first commit to this issue’s fork.

ggh’s picture

ggh commented
Status: Active » Needs review