Problem/Motivation

As title

Proposed resolution

Remove redundant assertion messages at the same time.

Example:

-    $this->assertTrue(isset($ids['entity_test.entity_test.field_test_import']));
+    $this->assertArrayHasKey('entity_test.entity_test.field_test_import', $ids);

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 rules-replace-isset-top-assertArrayHasKey-3136850-2.patch1.52 KBandrewsizz

Comments

AndrewsizZ created an issue. See original summary.

andrewsizz’s picture

andrewsizz commented
StatusFileSize
new rules-replace-isset-top-assertArrayHasKey-3136850-2.patch1.52 KB
andrewsizz’s picture

andrewsizz commented
Assigned: andrewsizz » Unassigned
Status: Active » Needs review
tr’s picture

tr commented
Status: Needs review » Postponed (maintainer needs more info)

Can you please combine your five issues into just one issue and explain *why* these asserts need to be changed?

tr’s picture

tr commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

There are currently no assertions involving calls to isset() in the Rules codebase.

tr’s picture

tr commented
Status: Closed (outdated) » Needs review

Actually, #5 wasn't true. There are two left, which are the same as in the patch.

  • TR committed 5a891c9 on 8.x-3.x authored by AndrewsizZ 
    Issue #3136850 by AndrewsizZ: Replace assertions involving calls to...
tr’s picture

tr commented
Status: Needs review » Fixed

Committed #2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.