Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs review

https://github.com/fago/rules/pull/432/files

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

I don't think the schema should be float - I can see nightmares with PHP turning 3.0 into 2.9999999999999999 or similar. Just use string?

fago’s picture

fago
Primary language German
Location Vienna
commented

I can see nightmares with PHP turning 3.0 into 2.9999999999999999

I've no idea why it would do that, but I'm fine with changing this to a string.

fago’s picture

fago
Primary language German
Location Vienna
commented

ok, changed that and fixed tests.

  • fago committed 47ac3f7 on 8.x-3.x 
    Issue #2682531 by fago: Store rules config version instead of the core...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.