Here's a patch that helps the module keep up with the Drupal coding standards. I used the coder module to determine most of these: http://drupal.org/project/coder

I think that this theme has a lot of potential and, if you want, could be considered for inclusion into Drupal7 core. It looks really pretty and if it is built in a clean manner (from a code style perspective) then that will be easier.

Great work. Keep it up.

CommentFileSizeAuthor
#1 code_style_notices_227639.patch6.24 KBgreggles
code_style_notices.patch6.02 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new code_style_notices_227639.patch6.24 KB

another small improvement in tab style and variable initialization.

sign’s picture

sign commented
Status: Needs review » Fixed

Commited,

I must admit, that I didn't took time to clean it up and handling variables as you did is much more better. Well I should do it from begining. Must learn. Also coder module is new to me, will use it from now. :)

If this could be considered for inclusion in D7, it will be great.

Thanks a lot!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.