Sort option list by weight

The option list for the field should be sorted by the weight for the corresponding role. This is the way it works for the regular role setting when modifying a user.

The rolereference_potential_references() calls user_roles() in order to build the list, but it doesn't use it in a way which will respect the weight. A minor code change in the foreach loop will change this behavior.