Problem/Motivation

The site template was cloned from the reference template and inherited its links to the distribution's own product pages. A client installing this template gets a magazine whose navigation, footer, pages and patterns point at Varbase documentation and a Vardot sales form.

Two of those links are also broken, which settles the question. The stored URIs carry the ampersand as an HTML entity rather than as a character, so the query string is parsed as one parameter named utm_source and a second parameter literally named amp;utm_campaign. The campaign tracking has therefore never attributed anything. This is shipped broken configuration, not a matter of taste, and it survives a visual review because the link text looks unremarkable and nobody reads a query string.

The links are spread across menus, page regions, patterns and default content:

  • menu links for About Varbase, Community Support, Documentation and Get Professional Support, plus the now-empty Support parent that held the last three;
  • a footer logo block using the distribution's logo and offering "get a quote" for enterprise support, and a "Powered by" block beside it;
  • buttons on the contact and features pages and in two patterns, pointing at Varbase documentation and a Vardot solutions page.

Steps to reproduce

  1. Install the site template on Varbase 11.
  2. Log out and look at the footer: it credits the distribution and links to a sales form.
  3. Open the Features and Contact pages and follow the buttons: they leave the site for product documentation.
  4. Inspect any of the tracked links and note the parameter named amp;utm_campaign.

Proposed resolution

Remove the product links. Where a button named the product, remove the button, because an absent link is honest and a replacement destination would be a decision nobody has made. Where the label was generic, point it at a page this template already ships.

The four social links stay. Educare and Horizon Aid both keep theirs, so removing them here would diverge from two templates on one template's initiative.

This is not made redundant by the offcanvas header change. That work rewrites the footer page region, which is the placed footer. The footer_global pattern is its twin and carries the same two blocks, so an editor placing "Site Footer" would reintroduce both after it merges. The page region is deliberately left untouched here to avoid a competing edit.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ❌ UX/UI designer responsibilities
  • ❌ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • The main and secondary menus lose their product links; the footer stops crediting the distribution.
  • Buttons that led to product documentation are removed or repointed inside the site.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Removed the Varbase and Vardot product links the site template had inherited, from its menus, footer, pages and patterns.

Issue fork rightup-3621522

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue.

  • rajab natshah committed 4f0ca9c0 on 1.0.x
    fix: #3621522 Remove the Varbase product links from the menus, pages and...