Revisioning Module Delete Issue

Mmmh, this seems like a feature provided by Revisioning. So this should be discussed there, shouldn't it?

In addition: By assigning an issue to yourself, you show that YOU are working on a solution (providing a patch for example). Feel free to correct the tags.

Thanks for handballing this to me dddave!

@gupta.sandeepcs: not sure which version of Revisioning you were using, or in fact whether you were using it at all.
Can you please upgrade to the latest version (and also upgrade Module Grants to the latest) and report whether the issue persists?

Ok, I'll look into it.

Gupta,
I have researched this a bit more and it occurred to me that in Drupal, if the user is user 1 OR has the administer nodes permission, they can do ALL operations (view, update, delete) on ALL nodes.
Have you made sure to switch this permission off for the account that is logged in when you observe this behaviour?
See also the Revisioning tutorial, point 7.
Rik

Thanks for the screenshot Gupta,
Apart from Module Grants, are you using any other modules that may affect content access?
From you introduction it seems you're using the Workflow module, is that correct? Any others? Taxonomy Access Control or TAC-Lite ?
What workflow permissions have you set up there for the role that should not see the "Delete all revisions" link? Another screenshot would be great.
What happens when you disable Module Grants, leaving Revisioning enabled?

Hi Gupta,
Now that you've confirmed you use the Workflow module, I believe the issue comes down to this. The Workflow module has node-granularity, it is not aware of revisions. Therefore any permissions you assign to a role+state combination are with respect to the node as a whole.
There is little that Revisioning can do about that.
How about unticking the Workflow delete permission and ticking the "delete own content" permission (node section) for the author instead? This will also be a compromise though, as the node section permissions do not know about Worklfow, so will apply across all Workflow states, ie. the author will be able to delete their content at any point.
Alternatively do not grant any delete permissions at all to authors. This means while content may be unpublished and thus hidden from the public eye, it cannot be deleted from the database (at least not by authors), so that your site automatically keeps a full "audit trail" of all content ever created. This is not uncommon in many a company.

I share your frustration... I was surprised I had to develop Revisioning because there didn't seem to be a comprehensive (let alone ideal) solution for publication workflows in this system that calls itself a CMS....
The Workflow module was not developed at the same time as Revisioning, so that's why the pairing-up of the two modules is less than perfect....
The benefit of hind-sight is always 20/20 isn't it.... ?
But Drupal is still pretty awesome, don't you think?

Subscribing. I'm having the same problem. Regardless of how I change the configuration, the "Delete all revisions" is shown for all users who can edit book pages.

Installed modules: Workflow 6.x-1.3, Revisioning 6.x-3.4, Module grants 6.x-3.4. (I know, I should upgrade all three to the lastest versions. I will do this during this week.)

I have the following configuration setup:
Workflow: No users are allowed to delete revisions in any state.
Module grants: "Interpret absence of access grants as a "don't care", rather than a "deny access" enabled, other settings disabled.
Drupal permissions: Permissions "delete any book content", "delete own book content" and "delete revisions" = disabled for all users.

If this is a Revisioning issue I don't know. It seems more like a Module grants issue to me.

@eriktoryra, #19:
Your specification of the Drupal permissions isn't 100% clear to me. Are you saying that all three ("delete any book content", "delete own book content" AND "delete revisions") are disabled? And that with all three disabled the "Delete all revisions" button is still visible? If so, I just tried that (Revisioning 6.x-3.8 though) and I cannot reproduce your issue... It all works fine for me...

@RdeBoer: Yes, that is correct. All three of those are disabled for me. I will upgrade to the latest versions of the modules today and then get back to you.

@RdeBoer: I have just updated the modules to the latest ones available without doing any configuration changes to the modules. The "Delete all revisions" button doesn't show up after the update. So, this seems to be an issue with the older releases.

I have updated the following modules:

Workflow
Upgraded from 6.x-1.3 to 6.x-1.4.
Revisioning
Upgraded from 6.x-3.4 to 6.x-3.9.
Module grants
Upgraded from 6.x-3.4 to 6.x-3.5.

@gupta.sandeepcs: Could you confirm which versions of Workflow, Revisioning and Module Grants you're using?

I have this same problem and have the most up-to-date versions of the three modules (revision, work flow, module grants) that are recommended for work flow. The author role I created, which I wish to give limited control to, is presented with an option to "delete all revisions." There is no way to assure that my users will not accidentally hit this button and the repercussions are pretty dramatic if the revision deleted is a page with important content, or, even more devastating, when that page is tied into the primary menu as a parent item and all of the items below it are promoted to top-level primary menus!

I don't know.... are you sure you haven't given the author the "delete own|any page content" permission? That's where the "Delete all revisions" button comes from, because you're deleting the entire node .... with all its revisions.
That "Delete all revisions" button is not related to the "delete revisions" permission. That's for individual revisions (but requires "delete own|any page content").
Confused? Tell the guys who wrote D6 core!

Hello, any solution ?

Are any of you using og as well? I am seeing this problem related to "admins" of the group. I will look there for more, but thought I would mention in case some are overlooking it

Thanks, useful to know! We need reproducable test cases.

Hi Gupta,

Your screenshots attached to #13 show that you have given the author role permission to "Delete in draft state".
From core and Workflow's point of view "Delete" means "Delete the node" or in other words "Delete all revisions" (which is just a re-labelling of the "Delete" button to make it extra clear that you're deleting all revisions not just one).

As strange as it may sound to you, it is impossible to give someone the right to delete a single revision without also giving them the right to delete the entire node, i.e. all revisions.
In other words "delete ... .content" permission is a pre-requisite for the "delete revisions" permission.

As a workaround I suggested in #14 to not grant any delete permissions at all to authors. This means while content may be unpublished and thus hidden from the public eye, it cannot be deleted from the database (at least not by authors), so that your site automatically keeps a full "audit trail" of all content ever created.

Rik

Hi Gupta,
I agree with you and your wishes -- I was merely stating that in terms of coding this, we'd have to "work around" what core normally does.
A further complication is that for historic reasons the Workflow module is NODE-based, while Revisioning is REVISION-based.
I'll give it some more thought and will get back to this thread later....
Rik

No activity for nearly a year. Has this request gone away?

There has been no activity here for a year and a half and Revisioning has since progressed to version 6.x-3.13 (with 6.x-3.14 about to be released).
Closing.
If there is still a problem, then please open a new issue, clearly stating steps to reproduce.