Hi,

I would like to request Views support for this module.

The addition of Views would allow extended functionality of Revisioning such as creating workflow blocks, revision pages, sorting and display by taxonomy etc.

Many thanks,
Danielle

Comments

rdeboer’s picture

rdeboer
Location Melbourne
commented

Hi Danielle,
I'm happy to look into this a bit more. Can you elaborate on the features you've mentioned? Do you have any pointers to existing examples of similar functionality?
Doesn't the 'My content' menu option already give you "display by taxonomy" (as well as Worklow state for that matter, if the Workflow module is installed, see the screenshot on the Module Grants project page).
Rik

dinis’s picture

dinis commented

The main thing I'm trying to achieve is a workflow block and page for the content moderators so they have a visual clue when there is something in their workflow. I'm trying to get Revisioning to work seamlessly with Workflows and Actions, the idea is to bring new content moderation and revision moderation into a single dashboard but it feels really messy at the moment.

With Views, Modr8 and Revision Moderation I'm able to do this perfectly under Drupal 5 (though I have to disable the standard blocks provided with those modules and build my own in Views). Unfortunately, Revision Moderation is not fully functional in D6 yet, also I feel that ultimately Revisioning should be able to offer dramatically more sophisitcation if I stick with it.

Anonymous’s picture

Anonymous (not verified) commented

I personally would be happy with just the block from Revision Moderation , but anything of this nature would be good. If it can be done without views all the better as it reduces the module count, though I find it hard to believe there is anyone on the planet not using Views :)

so +1 for this feature

rdeboer’s picture

rdeboer
Location Melbourne
commented

@Dinis, #2

Thanks for sticking with Revisioning!
Perhaps before we start talking implementation details (i.e. whether to integrate with Views or to extend functionality of Revisioning itself, or maybe even write an extension to Workflow) could you attach a description (eg bullet points) and/or screenshot (D5 is fine) of the sort of dashboard that you're after, please?
It would help me (and others reading this thread) in trying to get our brains around the mental picture in your head.

rdeboer’s picture

rdeboer
Location Melbourne
commented

@midkemia, #3

"I personally would be happy with just the block from Revision Moderation but anything of this nature would be good"

Hi John,
What do you feel the 'Pending revisions' block of Revision Moderation offers that Revisioning's 'Pending' tab under 'My content' doesn't?
Revision Moderation's block, available only to those with the "administer nodes" permission, just shows a list of node titles. Then at the bottom of the block there's a "View all pending revisions" link that takes you to /admin/content/node/revisions, i.e. Administer>>Content management>>Content, which shows a summary similar to My content>>Pending, except that Revision Moderation doesn't show taxonomy terms or workflow states.
Is it the fact that you're keen to have a block rather than a menu option?

The nice thing about the 'My content' tab is that it reflects what the logged-in user has access to.
So if they logged-in user has "administer nodes" permission, they'll see the lot. If they're an author they'll see the stuff they can view and edit (which may include content created by other authors in the same role). If they're a moderator then they'll see the stuff they can moderate. And if they're Joe Bloggs-with-no-rights then they're likely to see nothing under 'Editable' or 'Pending' and a limited amount under 'Viewable'.

What am I missing?

Rik

PS: adding a "pending revisions" block a la Revision Moderation would be a cinch; it's just that you're the first to ask and at this point I don't see it adding a lot of value -- but I am willing to be convinced otherwise!

Anonymous’s picture

Anonymous (not verified) commented

Hi Rik

As we all know in this perfect world of ours users are lazy, especially the admin, me :)

Seriously the big advantage I have found for the block is that I can place it at the top of the right sidebar. Then the moment the moderator hits the website they have a list of content that needs review. clicking the link gives instant access to edit etc., and on saving the block is updated. If while they are moving around the site new content appears, again they have instant visablility. The only thing i didnt do is try setting up block visability so that the block is only visible when there is something to do.

In this case we have a 1 click access to the node needing review

The problem with the Tab is first you have to go to your account block. which is often towards the bottom, Then you have to select My content, Then the appropriate Tab ( though by default , pending, the one you want is selected). Once your at the pending tab, you then select the content you want, and then the revision

So in total we have 3 clicks to access the node needing review

Therefore the justifications for a block come down to Speed and Visibility. Another benefit is that if you have the same/similar functonality, you might pick up a few more of their users for this module as its 6 month since the last release, and no permanet fix from what I rememeber ( Infact it may be worth seeing if they want to be merged with this if its appropriate :) )

As you say the Revisions Moderation block has a link at the bottom to take you to the "My Content", I personally think tyhis is a good idea, though i rarely used it, just got on with the task in hand. The only time I would use it was to find a particular node that I knew was being edited. Under general circumstances though, I didnt want the fright of how much needed to be done. A nice small list in the block looked more friendly and less intimidating . :)

In my case the block was visible to those with 'view revisions', this was part of the tweak i mentioned elswhere. I had assigned my moderators the ability to view revisions, as then needed to be able to see whats changed (no Diff module), and therefore overcame the "administer nodes" issue giving them too much.

I consider the Menu entry method as more of an expanded tool, bit like the link was with the block, only used when really needed as their was a quicker way

John

rdeboer’s picture

rdeboer
Location Melbourne
commented

Ok John,
Worse things have been done in the name of laziness and fear of intimidation...
Although the thing that sold it (the block in the upper right corner of every or nearly every page) for me is the fact that it gives the user a defacto alert the moment new content comes in for moderation (provided they regularly visit other parts of the site). They don't have to remind themselves to check the moderation queue, that check comes out of the wash of clicking about on the site.

So you shall have your block.

But first I'm going to have a glass of pinot noir :-)

Rik

PS: a bit of background... in researching, for a customer, moderation functionality and content approval workflows in Jan/Feb of this year I did came across Revision Moderation. I contacted the author but she said she was no longer involved in the project. I then contacted the maintainer at the time, but never heard back. This lack of time/interest combined with the fact that Revision Moderation has some subtle but serious flaws (in particular with respect to security and access control), which required a rewrite rather than a few easy patches made us decide to go it alone -- we had a customer to serve.
After delivery to the customer we then realised that the functionality was probably useful to a wider audience and we contributed the module(s) back to the community in the spirit of being a good open source citizen.

dinis’s picture

dinis commented

Ah, I seem to have missed this thread being active :)

I'm doing some UAT with the client this morning, then later I'll show you what I have so far and how I think we can make the system even better (and I feel provide something Drupal users all over will massively benefit from).

Many thanks for your outstanding work with this module.

Kind regards,
Danielle

rdeboer’s picture

rdeboer
Location Melbourne
commented

@Dinis, #8
Thanks for your support. Look forward to your suggestions.

rdeboer’s picture

rdeboer
Location Melbourne
commented

Re pending revisions block, midkemia comment #3

This is now checked into the module repository and should be downloadable as a development snapshot at the next schedule time, probably around 2 pm today (Fri 22 May), UK time.

A few notes on how to use it.
First, you must use it in tandem with a very recent (22 May or later) development snapshot of Module Grants.
After you've installed both Module Grants and Revisioning, go to Administer>>Site building>>Blocks and you'll find in the list of blocks available to you one named Pending revisions.
Configure it as per normal.
You'll find that there's a new option "Maximum number of pending revisions displayed" with a default value of 5. Pick any value. Setting it to zero will cause the block to not appear at all (not even its title). So this is an alternative to placing the block in the 'None' region.
As with any block, the admin can choose which roles may see the block and on which pages. However, in addition, the logged-in role must have the view revisions permission or it won't show.
Finally, going back to the previous page, choose a region of the page to put it in (maybe on the right) and save the configuration.

The block should appear with a title of "# revisions pending", the # being the total number of pending revisions, which may be greater than the number of revisions displayed in the block (up to 5 by default, but configurable by admin as mentioned above).
The title of the block also acts as a link to the 'My content >> Pending' tab.
The revision titles are links taking you straight to the content of the revision in question for the usual operations, including one-click publish and the handy "Compare-to-current" (install Diff module for this handy feature).
Finally with each revision title the block also shows the user who just modified the node, thus creating the revision.

To make the difference between "creator" and "last modified by" clear, I have added a 'Creator' column to the 'My content' page.

Enjoy -- let me know your feedback and if it doesn't look too buggy I'll promote the development snapshot to an official release.
Rik

Anonymous’s picture

Anonymous (not verified) commented

Hi Rik,

Many thanks I will download in the morning, just to make sure, and have a play. It sounds like it will be ideal. Is the block themeable? In that I could apply a different colour to the block header, so it stands out from other blocks. Also if their are zero revions to display, does it disappear? This may be a nice selectable option if not already present.

Now to get back my lengthy response on the other thread :)

regards
John

Anonymous’s picture

Anonymous (not verified) commented

HI Rik,

Installed earlier than expected, looks good

It has brought up a point I had not considered, and it may even be a small bug, and that is it shows all Unpublished nodes, whether they need moderating or not.

At first I thought the ability to define what content types were shown in the block was needed, but this needs careful administration to ensure that all of the contnet types needing moderation were selected, but thinking on it, it is more of a case of only nodes for content types where "New revisions in moderation" is selected should be listed,

I would also be inclined to leave off the username, as not only does it provide an extra, and possibly unnecessary link, which can be selected by mistake. OK I did it :), it is also using valuable realestate in the sidebar as it grows the size of the block. Besides you get to see the username whan you follow the node link anyway.
So unless someone can show a case where its useful, i would say remove it

John

Anonymous’s picture

Anonymous (not verified) commented

Hi Rik

re #11

I figured out how to theme the block in my css, now its just a case of finding the right colours

Anonymous’s picture

Anonymous (not verified) commented

Hi Rik

More on #11

Make block dissaper when no content pending

I tweaked the code for * Implementation of hook_block(). specifially case 'view'. Added an If not empty around the foreach. Have tested it here, and if their are no nodes pending the block is gone. Coding may not be perfect, and formating of the code definitely isn't :) But it does work. Tested for a Moderator and User 1 

    case 'view':
      $max_num_shown = variable_get('revisioning_block_num_pending', 5);
      if ($max_num_shown > 0) {
        $nodes = get_nodes('update', TRUE);
        $links = array();
        $i = 0;
     
if(!empty($nodes)) {
        foreach ($nodes as $node) {
          if ($i++ >= $max_num_shown) {
            break;
          }
          $links[] = l($node->title, "node/$node->nid/revisions/$node->vid/view")
            .' ('. theme('username', user_load(array('uid' => $node->uid))) .')';
        }
        $block = array();
        $block['subject'] = l(t('!count revisions pending', array('!count' => count($nodes))), 'content/pending');
        $block['content'] = theme('item_list', $links);
        return $block;
           }
       return;
      }
  }
}

and #12

I have also experimented with removing the username

was

          $links[] = l($node->title, "node/$node->nid/revisions/$node->vid/view")
            .' ('. theme('username', user_load(array('uid' => $node->uid))) .')';

is

          $links[] = l($node->title, "node/$node->nid/revisions/$node->vid/view");

Again seems to work a treat

rdeboer’s picture

rdeboer
Location Melbourne
commented

Hi John,
I can see where you're going with suppressing the name of the user who just modified the content -- lack of space.
Maybe the block should be configurable in the maximum number of characters shown for each revision title?

I'm not sure whether not showing anything is a good idea. Wouldn't users wonder whether the system works? The fact that it confirms that there are zero pending revisions seems like a useful feature to me (and is also what Revision Moderation does).

Your remarks regarding showing only content that has the "New revisions in moderation" box ticked make sense. I'll need to research this a bit more.
Rik

Anonymous’s picture

Anonymous (not verified) commented

Hi Rik,

In reverse order

"...Your remarks regarding showing only content that has the "New revisions in moderation" box ticked make sense. I'll need to research this a bit more...."

I had a play, with adding revisions_moderation true (which i believe was the correct variable) to th eCASE view
if ($max_num_shown > 0) but i ended with only 1 node being visible. I think i am on the right track but ...

"....I'm not sure whether not showing anything is a good idea. Wouldn't users wonder whether the system works..."

I dont think its an issue. If the system is being built properly the admin should at least do a test content to ensure each role is configured correctly. I did exactly that yesterday for my moderator and user. In my case i have also themed the block, so that it stands out in a different colour to the main theme. Instant announcement of moderation required. If this could be a built in option even better, though I am not sure how or if it would work, as i assume themeing comes after.

"....lack of space..."

Restricting the length is not a good idea as you will see below

My Super Big Content of Great Things Part 1
My Super Big Content of Great Things Part 2
My Super Big Content of Great Things Part 3
My Super Big Content of Great Things Part 4
My Super Big Content of Great Things Part 5

To mee Complete Title is OK, and if their is a long one, then so be it. However adding usernames which again could be long, may just be a little too much. Though I would like to see how others value the Username in this instance, it might be a case for a switch to turn it off in admin

regards
John

rdeboer’s picture

rdeboer
Location Melbourne
commented

Re "revisions pending" block -- new development snap-shot available at next scheduled release (25 May).
The block now disappears entirely if there are no pending revisions and pops back up the moment a new revision comes in.
The revision author name was dropped -- only the title of the revision is shown.
Order of revisions shown is oldest at the top, i.e. the opposite of what the tabs under 'My content' do.

rdeboer’s picture

rdeboer
Location Melbourne
commented

@Dinis, #8
So in the development snapshot of Revisioning (requires latest development snapshot of Module Grants) we now have a "revisions pending" block and new content filtering tabs under the new "My content" (now: "Accessible content" menu option).
Look forward to your suggestions as to where to go from here with dashboards, Views etc...!
Rik

attheshow’s picture

attheshow commented

Subscribing.

crea’s picture

crea commented

I believe we just need to make Workflow and Revisioning work better, and then you can use Views by Workflow state. Revisions don't describe state of content, while Workflow should, and when for example moderator is looking for current tasks, he should be able to find content with pending revisions by workflow state.
OTOH, if someone would want to work with revisions without using Workflow module, integration of Revisioning itself with Views would make sense indeed. But then it would be duplicated functionality.

crea’s picture

crea commented

After I realised you actually duplicated Views functionality here I think Views integration makes sense indeed. For that we would need to have separate table and expose it to Views so Views could use it in it's queries (JOINs and such). I think it would be great idea to implement it together with revision states in 3.x version of Revisioning.

crea’s picture

crea commented
Version: 6.x-2.3 » 6.x-2.x-dev
BenK’s picture

BenK commented

It would be great to make the "Accessible content" page (the one created by the "Module Grants" module) into a series of Views. This way, we would be able to change the displayed fields to any that we needed and also create new Views to make other listings of moderated content.

Best,
Ben

crea’s picture

crea commented

Yes I mentioned that before, when we implemented "view revisions of own content" permissions. I think Rik is aware of this.
We just need someone to code this :)

rdeboer’s picture

rdeboer
Location Melbourne
commented

I agree that a view would be great.
However I suspect there's some complications in implementing it, as the data shown under "Accessible content" isn't a straight "view" of the database. The data is filtered by the special Module Grants content access function. Is it easy to pass the data through this filter in the context of a view?

dinis’s picture

dinis commented

Hi All,

Has there been any progress toward adding Views support to the module?

I would really like to start using Revisioning but I need revision approvers to be able to see their workflow in a little block rather than have to hunt for it, and adding views support would make adding revisioning status to the existing workflow block a very simple job.

*quick edit* I think I've found a way to achieve what I need by using a combination of Rules and Flags along with Revisioning, I'll test further later.

Kind regards,
Danielle

junro’s picture

junro commented

Subscribing for using Views, I would be much interesting for all Drupal users.

How to take off the Term column please? I've got to many terms in some nodes...

Grants module doesn't have a template file to modify the display.

We can't customize tabs; or add a node type filter, don't we?

rdeboer’s picture

rdeboer
Location Melbourne
commented

As far as taking the Term column off... I guess it wouldn't be too hard to allow the admin to set a limit on the number of characters displayed, with zero causing the suppression of that column.
No you can't customize (as in create your own) tabs, you can only suppress or display the pre-defined ones per role (under User management >> Permissions). Nor can you filter on node-type.
Question is can we do all of these things with Views given the nature of the underlying data...., see #25.
This needs some more research.

junro’s picture

junro commented

ok thanks,

If you success to integrate views to your modules, Revisioning and Grand module with the addition of Deff module, it will be the perfect system to a wiki website! :)

davegan’s picture

davegan commented

+1 for Views integration. I want editors to have one single view to manage the content on the site. Workflow + Revisioning + Views + Bulk Operations would be the perfect way to do this.

ccdechesney’s picture

ccdechesney commented

I want to use Revisioning + Views + Bulk Operations + Rules so I can roll my own dashboard blocks for various roles. I'm using a CCK field instead of WorkFlow - the permissions on Workflow got to be so confusing I removed it. I've gotten quite a bit of it working, but have some issues. The only question that really applies to this thread is this: why is the revision author the only relationship I can set up in Views? Why not content author? Did Revisioning change this when it was installed, or was there no possible relationship without Revisioning?

rdeboer’s picture

rdeboer
Location Melbourne
commented

At this stage Revisioning itself doesn't do anything with respect to Views, certainly not setting up relationships.... Could the behaviour you experience be a side-effect of something else?

ccdechesney’s picture

ccdechesney commented

I've done more research on Views and on how Drupal modules interact - I'm new to Drupal - and it seems that everything is working quite well with Views. I didn't understand that to get a relationship to the author of the original content I needed to specify "no relationship", and also I wanted to create a View that was of type "node revision" not "node". Thanks for all your work on Revisioning.

rdeboer’s picture

rdeboer
Location Melbourne
commented

Thanks ccdechesney,
So did any useful Views come out of your work mentioned in #33 that you'd like to share with the community re Revisioning?

ccdechesney’s picture

ccdechesney commented

The basic Views are working fine but there is a problem with VBO and actions re node revisions. kratib will work on this and when it's working I'd be happy to share.

jpklein’s picture

jpklein commented

I don't know if this is design goal of the current development, but it would be great if this module exposed its definition of node revisions to Views as Filters and Arguments.

For example, while editing a View, I would like to add a new Filter from the "Node revision" Group like:
- "Node revision: current revision (published)", or
- "Node revision: most recent in draft/pending"

rdeboer’s picture

rdeboer
Location Melbourne
commented

Good idea JP!
It would be a great first step towards Views integration.
Anyone time to code it?
Rik

rdeboer’s picture

rdeboer
Location Melbourne
commented

Taken from related thread #602146: view last published revision; edit only most recent

"... a couple of new fields in Views, similar to the current Node: Edit link, something like
Node: Edit latest revision link and
Node: View latest revision link"

eriktoyra’s picture

eriktoyra commented

Subscribing. +1 for Views integration. It would be very useful when setting up content moderation using Revisioning + Workflow together with OG. Seems impossible to make a content moderation queue work with respect to OG access restrictions etc. I have failed to implement it in both D5 and D6.

olafdunn’s picture

olafdunn commented
Version: 6.x-2.x-dev » 6.x-3.4

I'm looking to create an XML feed through Views that can output either published content, or latest revision (not yet published).
I have changed the settings Node: View latest revision link but this does not seem to effect Views, only when you access the Node directly.

Is there any fixes for this?

Thanks

rdeboer’s picture

rdeboer
Location Melbourne
commented

You are right. That would be part of the requested Views integration.

rdeboer’s picture

rdeboer
Location Melbourne
commented
Assigned: Unassigned » rdeboer
Status: Active » Fixed

Re Views integration: Revisioning version 6.x-3.6 has the basics in place. Two new fields are available when creating views of nodes or views of node revisions:

o Node: State (one of pending, current, archived)
o Node Revision: State (one of pending, current, archived)

The user requires "view revisions" permission to see these fields in views.
There are also Filters for each group, so you can filter by "one (or not one) of pending, current, archived".

I haven't created any "canned" views, yet. I'm hoping for feedback as to what most people feel should go in these to drive further development.
If you have any ideas, let's open a new issue for that.

dinis’s picture

dinis commented

This is fantastic news, I'll start playing over the weekend :)

Many thanks,
Danielle

rdeboer’s picture

rdeboer
Location Melbourne
commented

Actually try 6.x-3.7. It has:

o Node: State (one of pending, current, archived)
o Node: Number of revisions
o Node: Revision moderation (whether the node has the "New revisions in draft, pending moderation" flag ticked.
o Node Revision: State (one of pending, current, archived).

Also available are filters for all the above.

Plus: a canned view that you may use as a starting point to customise your view. It automatically appears in the navigation menu under "Content summary".

Rik

junro’s picture

junro commented

Content summary view is perfect! We can customize it as we need it!

Thanks Rik for it! :)

junro’s picture

junro commented

Pending revisions block can be replaced by a block created with the Content Summary view. Great :)

rdeboer’s picture

rdeboer
Location Melbourne
commented

Thanks Junro! Let us know if you have any suggestions to improve the default "canned" view or what should go in a canned 'Pending revisions' block.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.