Just implemented hook_admin_paths and added the next paths:

node/*/revisions/*/list
node/*/revisions/*/unpublish
node/*/revisions/*/publish
node/*/revisions/*/compare

Thanks!

CommentFileSizeAuthor
#4 revisioning-n2474369-3.patch1.14 KBdamienmckenna
#2 revisioning-hook_admin_paths-2474369-2.patch683 bytesruloweb
#1 revisioning-hook_admin_paths-2474369-1.patch620 bytesruloweb

Comments

ruloweb’s picture

ruloweb commented
StatusFileSize
new revisioning-hook_admin_paths-2474369-1.patch620 bytes
ruloweb’s picture

ruloweb commented
StatusFileSize
new revisioning-hook_admin_paths-2474369-2.patch683 bytes

Just moving the new hook at the top because it gets conflicts with another patches which adds code to the end of module file.

Any idea if this can be commited? it's just a small change.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: hook_admin_paths » hook_admin_paths doesn't check node_admin_theme variable
Status: Needs work » Needs review
StatusFileSize
new revisioning-n2474369-3.patch1.14 KB

The main part of this was already committed via #2680429: Use admin theme for extra node/*/revisions pages, but the variable check wasn't added, so lets just add that part.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2680413: Plan for Revisioning 7.x-1.10 release
StatusFileSize
new revisioning-n2474369-3.patch1.14 KB

The main part of this was already committed via #2680429: Use admin theme for extra node/*/revisions pages, but the variable check wasn't added, so lets just add that part.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

(sorry about the double-post)

The last submitted patch, , failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: revisioning-n2474369-3.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

The patch failed testing because there are no tests, see #2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present for details.

ruloweb’s picture

ruloweb commented

Hi Damien, do you think it is ready to commit?

Thanks.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

FYI we've been running the patch above on a production site for three years.