Steps to reproduce:

1. Create new piece of content with moderation
2. Publish revision
3. Edit published revision with "Create new revision and moderate" selected
4. View all revisions (you now have one published and live and one in the barrel, as it were)
5. Edit the unpublished revision, but when saving select either "Create new revision, no moderation" or "Modify current revision, no moderation". The unpublished revision will update, but if you view the revisions, the current published revision will now be unpublished.

This is a pretty big deal, I think as it means entire pages on your site start getting "Access denied" and your maintainers may not even know it.

A side-note: I've got it set so that only one unpublished revision gets made (not a new revision each time the unpublished revision is saved). So not sure if that has anything to do with the bug.

Comments

joevansteen’s picture

joevansteen commented

I've been trying to work through the bug list here to see which elements match behavior on my system in order to track down some bugs and hopefully find some fixes. I've also had this effect. I do not have the single revision setup, I have settings to create a new revision for each change.

When I made the change specified in step #5, after making other revisions and publishing them, I made the change to a new revision at the end of the series. At that point I ended up with a series of 6 saved revisions - the most recent of which was 'unpublished' i.e., the one I had just tried to save 'without moderation.' I would think, this should have resulted in a new published revision.

What is also interesting is that while unpublished, it fails to show up in the 'pending revision' block - so, effectively, part of Revisioning thinks it is finished with this item and it is sort of lost in limbo. It does still show on views for those who are authorized to see unpublished content, so it's not completely hidden. And once you are looking for it and it is found, it can be published.

rdeboer’s picture

rdeboer
Location Melbourne
commented
Assigned: Unassigned » rdeboer

A big thank you to both caseyc and joevansteen for their detailed issue descriptions.
I will have to set some time apart to sit down and try to reproduce and fix.
Rik

joevansteen’s picture

joevansteen commented

Rik,
Saw your update to the comment here, so I went back and retested after having applied the http://drupal.org/node/1243018 After unpublish & publish revisions, update node_access records patch. At this point, the problem seems fixed. Maybe it's three birds with one shot. Different symptoms of the same underlying issues?

I'd recommend more testing though.

Joe

rdeboer’s picture

rdeboer
Location Melbourne
commented
Status: Active » Fixed

#3:
The patch for #1243018: After unpublish & publish revisions, update node_access records has been applied, so following @joevansteen's experience, I presumptuously consider this one fixed too, until someone reports otherwise...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.