REST server doesn't include files defined in #file in the array returned from a service's hook_service(). For example, the node_service module defines #file to be array('file' => 'inc', 'module' => 'node_service'). Where required files are missing the service crashes.

The attached patch makes use of module_load_include to include the required file.

CommentFileSizeAuthor
#2 rest_server.module_file_include.patch1.16 KBnonsie
rest_server_include.txt816 bytesmleicester

Comments

robloach’s picture

robloach
he/him
commented
Status: Needs review » Needs work

Needs an update to HEAD! Thanks a lot ;-) . Sorry about this taking a while to get around to.

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
StatusFileSize
new rest_server.module_file_include.patch1.16 KB

Here's a patch against DRUPAL-6--1

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
Status: Needs work » Needs review

Changing status

robloach’s picture

robloach
he/him
commented
Status: Needs review » Fixed

Committed! Thanks a lot for the help. http://drupal.org/cvs?commit=182560

I added a check on isset() just in case Services doesn't pass the #file.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.