It's possible and quite common for users to have access to admin routes without having the 'access administration pages' permission. Drupal core then displays the route as a normal page. This is for instance the case when users edit their own user info.

When this happens this module should still do it's magic, but it doesn't. A simple access check in responsive_menu_page_bottom() should solve this, I believe.

CommentFileSizeAuthor
#3 2854137-admin-when-not-admin-3.patch713 bytesOWast

Comments

OWast created an issue. See original summary.

OWast’s picture

OWast
Location Ljusvattnet, Burträsk, Sweden
commented

Patch coming up....

OWast’s picture

OWast
Location Ljusvattnet, Burträsk, Sweden
commented
StatusFileSize
new 2854137-admin-when-not-admin-3.patch713 bytes
OWast’s picture

OWast
Location Ljusvattnet, Burträsk, Sweden
commented
Assigned: OWast » Unassigned
OWast’s picture

OWast
Location Ljusvattnet, Burträsk, Sweden
commented
Status: Active » Needs review
rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

I have this implemented as a patch via composer on a live site as I was suffering with broken menu when non-admin users were adding nodes. It corrected the broken menu for those users and does not appear to have caused any other issues.

I say this is RTBC.

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Gosh, I'm a terrible maintainer! I've been working on this issue over in #2455683: Responsive menu not working in administration or edit pages and I'm going to close this as a duplicate. Thank you both for your efforts. If either/both of you could test the patch in the other issue that would be most appreciated!