Fix the issues reported by phpcs [#3349232]

Problem/Motivation

Getting following error/warnings.

FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\representative_image\src\Plugin\Field\FieldFormatter\EntityReferenceRepresentativeImage.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\representative_image\src\Plugin\migrate\source\FieldConfig.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
42 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
-------------------------------------------------------------------------------------------------------------------------------------------

Time: 421ms; Memory: 12MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/representative_image/

Proposed resolution

Above error/warnings need to be fixed

Comment	File	Size	Author
#18	3349232-18.patch	3.4 KB	nitin_lama
#14	Screenshot 2024-02-14 161619.png	12.2 KB	shank115
#13	phpcs_fix.patch	1.95 KB	Shreyas gowda
#11	fix_coding_standard-3349232-11.patch	2.8 KB	Neeraj333
#2	3349232-2.patch	2.83 KB	samitk

Issue fork representative_image-3349232

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

8.x-1.x changes, plain diff MR !9
Check out this branch for the first time

Check out existing branch, if you already have it locally
3349232-fix-the-issues compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

21 March 2023 at 04:16

samit.310@gmail.com created an issue. See original summary.

Comment #2

samitk commented 21 March 2023 at 04:17

Assigned:	samitk	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	3349232-2.patch	2.83 KB

Above errors/warnings has been fixed.

Comment #3

21 March 2023 at 04:24

Status:

Needs review

» Needs work

The last submitted patch, 2: 3349232-2.patch, failed testing. View results

Comment #4

rassoni commented 21 March 2023 at 04:54

Title:	Drupal Coding Standards Issues \| phpcs	» Fix the issues reported by phpcs
Issue summary:	View changes
Priority:	Normal	» Minor
Issue tags:	-Coding standards Phpcs, -Phpcs Drupal coding standard issue

Comment #5

21 March 2023 at 05:41

shivam_tiwari made their first commit to this issue’s fork.

Comment #6

sagartiwari commented 21 March 2023 at 06:03

Assigned:

Unassigned

» sagartiwari

Comment #7

sagartiwari commented 21 March 2023 at 06:21

Assigned:

sagartiwari

» Unassigned

Comment #8

21 March 2023 at 08:06

shivam_tiwari opened merge request !9

Comment #9

shivam_tiwari commented 21 March 2023 at 08:07

Status:

Needs work

» Needs review

Comment #10

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 21 March 2023 at 08:56

Status:

Needs review

» Needs work

The tests are failing for a reason. See the plain diff of the latest MR created.

Comment #11

Neeraj333 commented 30 May 2023 at 10:38

Status:

Needs work

» Needs review

Status	File	Size
new	fix_coding_standard-3349232-11.patch	2.8 KB

Comment #12

30 May 2023 at 10:45

Status:

Needs review

» Needs work

The last submitted patch, 11: fix_coding_standard-3349232-11.patch, failed testing. View results

Comment #13

Shreyas gowda commented 8 February 2024 at 04:21

Status	File	Size
new	phpcs_fix.patch	1.95 KB

Comment #14

shank115 commented 14 February 2024 at 10:46

Status	File	Size
new	Screenshot 2024-02-14 161619.png	12.2 KB

I applied the patch provided in #13 and it applied successfully.

Comment #15

zkhan.aamir commented 15 February 2024 at 08:43

Remaining issues after patch #13.

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml representative_image/

FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\representative_image\src\Plugin\Field\FieldFormatter\EntityReferenceRepresentativeImage.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
 82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\representative_image\src\Plugin\migrate\source\FieldConfig.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 42 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
-------------------------------------------------------------------------------------------------------------------------------------------

Time: 421ms; Memory: 12MB