Problem/Motivation

On cache clear I'm receiving the following error a few times on the homepage which is a panelized page with entity_referened nodes:

Notice: Undefined offset: 2 in RenderCacheControllerEntity->getPageArgument() (line 127 of /sites/all/modules/contrib/render_cache/modules/render_cache_entity/plugins/render_cache/controller/RenderCacheControllerEntity.class.php).

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 notice_undefined-2351133-1.patch935 bytesjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new notice_undefined-2351133-1.patch935 bytes

Not sure if this is a good enough fix... but seems right to me so... sharing:)

Hopefully it doesn't mask a problem?

fabianx’s picture

fabianx commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed and pushed to 7.x-2.x!

If it can't find the argument, then it should silently assume that page is NULL.

I think this can happen if something calls the entity_view() method directly, which panels might do :).

fabianx’s picture

fabianx commented
Status: Patch (to be ported) » Fixed

Committed and pushed to 7.x-1.x! Thanks!

  • Fabianx committed 40e3bf9 on 7.x-1.x 
    Issue #2351133 by joelpittet, Fabianx: Fixed Notice: Undefined offset: 2...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Fixed » Needs review

I don't think this patch got committed/pushed to 7.x-2.x? Maybe something happened?

  • Fabianx committed 7c9eefa on 7.x-2.x authored by joelpittet 
    Issue #2351133 by joelpittet: Fixed Notice: Undefined offset: 2 in...
fabianx’s picture

fabianx commented
Status: Needs review » Fixed

Committed: yes, but not pushed.

This should be fixed now.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Thank you @Fabianx:) a few less patches to maintain today, love it:)

  • Fabianx committed 7c9eefa on DIC authored by joelpittet 
    Issue #2351133 by joelpittet: Fixed Notice: Undefined offset: 2 in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.