Enhanced functionality and usability of configuration UI.

Great stuff! I am sure that I speak for everyone that these make some nice additions to the mix.

I am just quickly scanning through and these are some things I'd appreciate if you can have a look at please.

I see you add 1814400 and then removed , 15552000, 31104000. Since others might be using the settings that are now removed this will pose a problem but I am happy if you add new ones, no problem. To stay DRY and simplify adding to the list lets define the options once and just pass it to each form element, what do you think? You don't have to duplicate them to add the 0 option see what you can do with a shift or merge I'm sure there's something in the list of array functions that will help.

I don't understand why you are removing #descriptions and now substituting title for its purpose, this seems counter productive. At this point I am alarmed by things being removed for no reason, again additions and modifications make sense but we shouldn't have to remove anything, am I right? Unless I am missing something.

Another add or modify but don't remove: "This setting is ignored if Manage session lifetime (above) is disabled." might be useful to know, wan't you agree?

The same goes for comments: // If we have cookie lifetime set already then unset it.
These help our sanity when we've forgotten or, like yourself when the next person tries to work out what exactly we were trying to accomplish here =)

Don't include whitespace changes in the patch please have a look at interactive mode:

git add -p

Which will allow you to only use the hunks that we want instead of the silly whitespace.

I will make some time to install this during the week and get back with some more feedback.
Since we are obliged to maintain the D6 version as well may I ask that you back port and roll a patch for that too, if you don't mind.

Awesome to have you on board, keep up the good work!

You know what, in retrospect, these are feature enhancements and not critical fixes which will pardon exclusion from the legacy implementation (D6) To be honest PHP 5.2 is rapidly getting out of my reach, unless we get at least +3 for its inclusion, the extra effort is not justified. I will even settle for +1, plus your +1 and my +1 would also make +3, that's fair right?

The interactive mode is available on several commands in git referred to either as -i or -p. In the beginning I found it odd mostly being uncertain which options to pick worried that I may loose something. But practice has proven even the most dodgy of the lot, arguably edit mode, will not even allow you to make a mistake. If anything I am uncertain when I committed something without git add -p and will habitually git reset HEAD^ to roll back the commit and quickly do it over so that I know its right, without even bothering to check since 9 times out of 10 its got junk. If you're not happy with what's been staged at any point, just q out of there and git reset will undo any mistakes, no sweat.

I also clean trailing whitespace and convert tabs by default and have no qualms to include whitespace fixes don't get me wrong but to aid with cherry picking they should preferably be done in their own patches so we don't have to worry that it changed anything and it wold probably make sense to touch all the source simultaneously to prevent future frustrations. These should include that irritating new line at end of file whitespace above any others. What do you say?

There's no rush take your time, much obliged! =) I am unlikely going to have a chance myself ether. Preoccupied with the next release of Luracast/Restler (see github) which is enjoying my free time right now. All good things...

@iSylence how is it going, are you making some time to wrap this up? I am very eager and excited to add your amazing additions so lets do this thing.

You know it's easier to quickly complete these things while still close by and fresh in memory, how quickly time flies and the cobwebs start settling. I'm marking it critical as every day that goes by increases the risk this patch going to dust and ashes, that would be a shame.

Looking forward to seeing your rerolled patch, can't wait.

Keep up the good work!

Hope this helps:

* Add don't remove
* Keep it DRY don't duplicate
* ignore whitespace
* All things awesome

I was thinking about elaborating but that is what all the previous text is about and you did want to avoid that so I hope this helps.

Looking forward to review your masterpiece =)

Looking good well done! =) Now that is what a patch should look like I want to frame it and put it on the wall.

Only one thing that I can see that may be a problem, please verify if I am mistaken.
This patch only includes the changes to the settings page but you are incorporating a new setting "override_session_default_lifetime" where is the implementation for that?

In the previous patch I see the following changed in remember_me.module.

if(variable_get('override_drupal_default_timeout') == TRUE) {
    if(variable_get('override_session_default_lifetime', 604800) != ini_get('session.cookie_lifetime')) {
        _remember_me_set_lifetime(variable_get('override_session_default_lifetime', 1814400));
    }
}

Is this not required anymore?

Woah... This has been here a long time...

This patch is currently being used by a few of our clients in the wild and is working well. And it has been for the last 4 years...

This is RTBC.

@Gold Thanks for the initiative. Please let us know by when can we expect the new release of this project.

@imkartik, I'm not actually involved with that side of things. However, there is currently a group that are going through the process of getting maintainership transferred to them. How long this takes is unknown to me.

Re-roll against latest dev.
Some small derivation from original patch is presented: I have removed added "Override default timeout" config section because 1) it was effectively duplicating already existing functionality 2) it wasn't actually working because hook_init() was using variable that is not exists(because of typo probably).

And it's totally not "Critical".