I would like to propose removing the size constraints that are currently in the relation-select's css and let it take on the size of the embedded view. This was an issue for me especially as I have quite a bit of data to show which looked quite bad in the default css.
I also moved the close button a pixel and propose to remove the borders on the inside of the view, this stalked me especially since I'm using VBO in combination with relation_select (I hope to be posting patches soon for improved VBO support in a different issue). To distinguish the pop-over from the background form I added a small 1px border in #ccc instead (this was the color used by the default admin theme).
Furthermore I changed the z-index from 1000 to 1, this is enough to go over the drop down menu's made by drupal (there's a change history in the preview attached) but is still low enough so that it doesn't go over the admin menu, which was one of my gripes. (I believe Admin Menu is used by enough users to warrant the change).
To be able to accommodate the 1px border I had to use jQuery's hide in the close() function and created an open() function that is triggered when the search form is submitted.
Attached is the proposed patch as well as a screenshot of its impact, sorry for blurring out the actual view data as it's proprietary to my client.
| Comment | File | Size | Author |
|---|---|---|---|
| proposed-ui-changes.jpg | 197.7 KB | kingdutch | |
| proposed-ui-changes-1.patch | 1.92 KB | kingdutch |
Comments
Comment #1
steveoliver commentedThanks, Kingdutch. Committed in deb8241.