Closed (fixed)
Project:
reCAPTCHA v3
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Jan 2020 at 21:42 UTC
Updated:
7 Feb 2022 at 07:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
luke.leberAdjust schema to allow for successful entity creation within tests.
Add coverage for entity list builder extension.
Comment #3
luke.leberCan the project maintainer(s) please enable testing for this project? Thanks!
https://www.drupal.org/node/1449736
Comment #4
tr commentedTesting is very important, and should be turned on even if there are no tests because testing will still catch syntax errors and coding standards and things like that. Plus it will allow patches like this to be tested!
Just a few notes:
You should set the issue status to "Needs review" when you post a patch - that way people know there's something to look at.
Your test should define
protected $defaultTheme = 'stark';See https://www.drupal.org/node/3083055
While this is not strictly needed at present, it becomes mandatory in D9, can be used in D8.8, and is ignored in previous versions of D8 core. Better to do it correctly now rather than to have to go back and fix this in the future.
I assume the changes to schema.yml are there because the test fails the strict schema check without those changes? If so, this is an even stronger reason to turn on testing and commit this patch!
Comment #5
luke.leber@TR - I was going to hold off on moving the issue to NR until the test runner reported green.
You are correct about the schema yaml changes.
Great call on the new $defaultTheme property! I forgot about that because my local test runner was set up to ignore deprecations (carry over from another project).
Comment #7
tr commentedI think this issue can be closed? It would also be nice to have a D9 test configured to run weekly so we could make sure this module stays functioning going forward.
Comment #8
dench0