Editing a clone before saving changes the source node.

It is not only that if you edit you are editing the source as well but also the relation is to the previous Cohesion entity.
I had to write custom code for hook_cloned_node_alter + to patch the acquia cohesion module in order for this to work cause of how its widget form element is written.

Here is the custom code, this will clone all entityrevision fields that are not paragraphs as they are already handled by quick_clone_node module though I think this makes sense to be done there instead of just only for paragraphs:

/**
 * Implements hook_cloned_node_alter().
 */
function custom_general_cloned_node_alter(\Drupal\node\NodeInterface &$node,
                                          \Drupal\node\NodeInterface &$original_entity) {
  $config_name = 'exclude.node.' . $node->getType();
  $exclude_fields = \Drupal::config('quick_node_clone.settings')->get($config_name);
  $exclude_fields = $exclude_fields ?: [];

  foreach ($node->getFieldDefinitions() as $field_definition) {
    $field_storage_definition = $field_definition->getFieldStorageDefinition();
    $field_settings = $field_storage_definition->getSettings();
    $field_name = $field_storage_definition->getName();

    if (!in_array($field_name, $exclude_fields)) {
      if (isset($field_settings['target_type']) && $field_settings['target_type'] != "paragraph") {
        $field = $node->get($field_name);
        if (!$field->isEmpty()) {
          // Could also use EntityReferenceRevisionsItem to check the first.
          // $first = $field->first();
          if ($field instanceof EntityReferenceRevisionsFieldItemList) {
            // @todo: clone
            foreach ($field as $value) {
              if ($value->entity) {
                $value->entity = $value->entity->createDuplicate();
              }
            }
          }
        }
      }
    }

  }
}

I am also attaching the patch for Site Studio.

Thanks for the patch, worked fine for me!

The only problem is that I'm using the cohesion version 8.x-6.9.3, then was necessary create a new patch compatible with this version.

If someone needs, is that attached, I will create an issue in Acquia for the product Site Studio too, maybe this change could be included in the module by them.

@vflirt - thank you for this fix - it works great and I would like to give RTBC+1 for us with:

- Drupal 10.1.8
- PHP 8.2.16
- Cohesion/Site Studio 7.2.1

Some important notes for those applying the fix:

1. The patch works in conjunction with the code snippet in Comment 2

2. The patch is for the package acquia/cohesion, not quick_node_clone, so if you are having issues applying with composer make sure the correct package is specified.

"acquia/cohesion": {
    "3272297 - Editing a clone before saving changes the source node (quick_node_clone)": "https://www.drupal.org/files/issues/2022-11-22/editing_a_clone_before_saving_changes_the_source_node-3272297-5.patch"
}

Should this be created as a pull request for acquia/cohesion instead of a patch here?

I was not quite sure how to move the ticket along, but I would agree a patch should be in the acquia/cohesion issue queue, but also the code snippet is necessary for this fix to work. Perhaps moving to the correct issue queue is a start, then maybe adding documentation regarding the custom hook?