Hi,
I have no idea what's the usage of the cron function, but what ever it is, it doesn't work due to this bug.
I attached the patch.

BTW : Your module is perfect for mass editing thanks for sharing it. keep up the good work ;)

CommentFileSizeAuthor
#4 cron security patch.patch664 bytessinasalek

Comments

sinasalek’s picture

Well, i guess this is a bug. because whenever i run cron, it publishes all the unpublished contents!

summit’s picture

Hi,

I do not see the patch please...subscribing, greetings, Martijn

sinasalek’s picture

There is no need for patch anymore since it cause some problems if it works. i guess it's a security issue because according to code :
It first select all the nodes that are non published and has been created before the current time (Which mean it selects all the nodes!)

$result = db_query("SELECT nid FROM {node} as n WHERE n.created <= %d AND n.status = 0", time());

And then it publish all the nodes and update their change time.

db_query('UPDATE {node} SET status = 1, changed = %d WHERE nid IN(%s)', time(), implode(',', $nids));

So if you have any unpublished nodes, this module will definitely publish them all, and anyone can see them.

sina.salek.ws, CIO & Lead developer
Feel freedom with open source softwares

sinasalek’s picture

Priority: Normal » Critical
StatusFileSize
new664 bytes

Changing to critical and a patch for remove the function.
You can also manually remove qedit_cron function.

jimyhuang’s picture

Status: Needs review » Fixed

Thanks for review, this is my fault that modified other module but forgot to remove unecessery function.
Commit to nightly snapshot.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.