When following the upgrade instructions, I noticed that the site_url wasn't changed when using --deploy.

I had to run provision verify sitename --site-url sitename to fix that setting. I have updated the UPGRADE.txt file so that people do that manually, but I now feel this is an issue in provision itself.

Comments

anarcat’s picture

anarcat commented

Actually, verify doesn't work because:

Initialized Drupal site hostmaster.koumbit.net at                       [notice]
sites/hostmaster.koumbit.net [0.073 sec]
Loading drushrc                                                      [bootstrap]
"/var/hostmaster/drupal-6.12/sites/hostmaster.koumbit.net/drushrc.php"
into "site" scope. [0.073 sec]
Drush bootstrap phase : _drush_bootstrap_drupal_configuration()      [bootstrap]
[0.094 sec]
Drush bootstrap phase : _drush_bootstrap_drupal_database() [0.103    [bootstrap]
sec]
Successfully connected to the Drupal database. [0.103 sec]           [bootstrap]
Drush bootstrap phase : _drush_bootstrap_drupal_full() [0.109 sec]   [bootstrap]
Site was not found. [0.342 sec]                                      [error]
An error occurred at function :                                      [error]
drush_provision_drupal_provision_verify_validate [0.343 sec]

I had to manually edit the drushrc.php file.

anarcat’s picture

anarcat commented
Status: Active » Needs review

I'm testing this patch:

cvs diff: Diffing .
Index: deploy.provision.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/provision/platform/deploy.provision.inc,v
retrieving revision 1.18
diff -u -r1.18 deploy.provision.inc
--- deploy.provision.inc        28 May 2009 05:56:08 -0000      1.18
+++ deploy.provision.inc        28 May 2009 21:44:52 -0000
@@ -93,4 +93,6 @@
     drush_set_option('packages', _scrub_object(provision_drupal_system_map()), 'site');
   }
   _provision_drupal_rebuild_caches();
+  // we probably changed the url since the backup
+  drush_set_option('site-url', $url);
 }
anarcat’s picture

anarcat commented
Status: Needs review » Needs work

So this issue remains, even with the above patch.

anarcat’s picture

anarcat commented
Status: Needs work » Fixed

The problem was the dash instead of an underscore (duh). The new site url is now fixed in deploy.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

anarcat’s picture

anarcat commented
Status: Closed (fixed) » Needs work

Actually, this is still an issue. I deployed my "hostmaster.koumbit.net" to "d6.hostmaster.koumbit.net" and it didn't change the ServerName. So the fix needs to happen before the apache verification kicks in somehow.

anarcat’s picture

anarcat commented
Status: Needs work » Fixed

Fix committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 44339e9 on debian, dev-dns, dev-envobject, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-simplerinstaller, dev-site_rename, dev-ssl, dev_716166_apache_conf, dev_dns, dev_server_verify, prod-koumbit, ssl, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by anarcat: 
    #475832 by anarcat - fix the site_url when deploy is finished
  • Commit 3941715 on debian, dev-dns, dev-envobject, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-simplerinstaller, dev-site_rename, dev-ssl, dev_716166_apache_conf, dev_dns, dev_server_verify, prod-koumbit, ssl, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by anarcat:
    #475832 - set the site_url in the pre hook instead of post so that all...