the settings menu for the provision module is badly broken. here, it crashes apache with what looks like an infinite loop.

The attached patch restores proper behaviour and also adds a submit hook, which seemed to be missing. I made it so the submit hook calls all provision modules.

CommentFileSizeAuthor
#1 mysql_submit.patch2.46 KBanarcat
mysql_submit.patch3.03 KBanarcat

Comments

anarcat’s picture

anarcat commented
StatusFileSize
new mysql_submit.patch2.46 KB

The first patch had some whitespace changes in it, this one is cleaner.

adrian’s picture

adrian commented

Thanks for the patch.

I'm currently busy refactoring this code, to keep pace with the move away from cck.

Due to the fact that I am doing all the forms for the types myself, I am moving the settings forms into provision, and merging them into
the node forms on the front end as necessary.

With some custom handling of the submit hooks, I will be able to provide a much simpler mechanism for maintaining the provision settings.
(the provision settings are tied directly into the platform that hostmaster is currently running as, so centralizing the codebase cleans up a lot of places where errors could creep in)

adrian’s picture

adrian commented
Status: Needs review » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.