The '--rsyncable' flag is invalid on OS X gzip, and an updated version via homebrew, which means that whenever a backup is created an error occurs, and even worse that error prevents migrating of sites between platforms.

Simple fix for the moment is to remove that flag from backup.provision.inc #90.

CommentFileSizeAuthor
#4 remove_rsyncable-1901508-4.patch495 bytesdeciphered

Comments

realityloop’s picture

realityloop commented
Status: Fixed » Active

The hombrew patch I wrote has been merged into homebrew-dupes now..

Run the following commands from terminal

Ensure that you don't already have gzip installed via homebrew:

$ brew uninstall gzip

Add hombrew dupes:

$ brew tap homebrew/dupes

Reinstall gzip via homebrew

$ brew install homebrew/dupes/gzip
deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Confirmed and working.

However, I would still recommend some sort of check to ensure that gzip supports the --rsyncable command before appending it to the command.

steven jones’s picture

steven jones commented

I'm not sure why we both adding this option anyway, as we don't rsync the same files over and over once they are gzipped.

Could you provide a patch that just removes the use of this option?

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review
StatusFileSize
new remove_rsyncable-1901508-4.patch495 bytes

Done and done.

omega8cc’s picture

omega8cc commented

Not sure, but I believe there was some reasoning behind this commit, no?

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

I'm fine for them to be rsyncable if it's necessary, but there really should be some sort of check for anyone who is running a version of gzip that doesn't support this flag, which based on my research wasn't added until after the current stable release of gzip (1.5).

omega8cc’s picture

omega8cc commented
Status: Needs review » Needs work

I have checked this on system upgraded from Debian Lenny to Squeeze, so it has gzip 1.3.12 instead of 1.4, and this version does support --rsyncable option. The fun part is that it is the same version which is used on the latest OS X 10.8.2, but on OS X it doesn't show the --rsyncable option as available, so I guess it is not really gzip version related but OS specific?

omega8cc’s picture

omega8cc commented

And for the record: http://beeznest.wordpress.com/2005/02/03/rsyncable-gzip/

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Ok, well I didn't research too hard, so my bad, but the patch we did find that added the flag was rolled against 1.5, and it does work adding the flag to 1.5 for mac (via homebrew).

Regardless, the mac version and the .15 version via homebrew doesn't support the flag and something should be put in place to prevent the flag from being used if it's not supported.

I'll re-roll later tonight.

steven jones’s picture

steven jones commented

Maybe we need to ask anarcat why he added the commit in question as there's no linked issue with any discussion that I can see?

We aren't changing backup files, so there's no advantage to using this option as far as I can see?

anarcat’s picture

anarcat commented
Status: Needs work » Reviewed & tested by the community

The reason why i added --rsyncable is that we use rsync or rsync-like algorithms to backup and move Aegir backups all the time. I figured it would save CPU time, disk IO and bandwidth.

However, as Steven correctly assessed, we probably don't *update* tarballs we have already created, so the effect of this is null. I think we can revert it.

Besides, it would probably explode with hellfire in Solaris and other weird platforms, so let's just ditch this.

thedavidmeister’s picture

thedavidmeister commented

Thanks for patch in #14, saved my aegir install from Mountain Lion. Took me longer that I would have liked to find this thread :(

anarcat’s picture

anarcat commented
Status: Reviewed & tested by the community » Fixed

committed, thanks.

realityloop’s picture

realityloop commented

See comment #1 If your using homebrew on OS X you can get rsyncable support using that method

thedavidmeister’s picture

thedavidmeister commented

#14 - you should totally update http://realityloop.com/blog/2012/07/03/nginx-mariadb-php-aegir-mac-os-x-... with the gzip patch

realityloop’s picture

realityloop commented

Added to step 1

Status: Active » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 693d0d4 on dev-drupal-8, 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by anarcat: 
    Issue #1901508 by Deciphered: Fixed gzip --rsyncable is invalid on OS X.