This module adds the ability to take currency rates from the Privat Bank.

Project link

https://www.drupal.org/sandbox/retrobon/3193477

Git instructions

git clone --branch 1.0.x https://git.drupalcode.org/sandbox/retrobon-3193477.git

PAreview checklist

http://pareview.net/r/72

CommentFileSizeAuthor
Screenshot.png88.41 KBbonzik

Comments

bonzik created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Commerce Exchanger Privat Bank » [D8] Commerce Exchanger Privat Bank
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +PAreview: single application approval, +PAReview: project created less than 10 days ago

Thank you applying! The master branch isn't used on Drupal.org repositories. The correct branch needs to be created and made the default one; after than, the master branch can be deleted. See Release naming conventions for the correct branch names.

In the .info.yml file, the version key isn't used. It's automatically added by the script that creates the project packages.

bonzik’s picture

bonzik commented
Issue summary: View changes

Thanks for the comment.
I made corrections

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs work » Needs review
maheshpa’s picture

maheshpa commented

Hi @Bonzik

Thank for applying for code review.

Automated Review

I visited the source code and reviewed through automated tool http://pareview.net. Please find link to get the details.
http://pareview.net/r/72

Also I recommend you to please install PHPCS automated code review tool.
https://www.drupal.org/docs/contributed-modules/code-review-module/php-c...

Manual Review

Coding style & Drupal API usage
Issue Listed are as below
  1. Please validate $request API client before using in code at line no. 42 in PbExchanger.php
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs review » Needs work
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -PAreview: project created less than 10 days ago
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

I am closing this application since there have been replies in the past 5 months.