Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Sep 2018 at 18:02 UTC
Updated:
5 Feb 2020 at 16:46 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoSee the errors reported by PAReview.
Comment #3
sheikh303 commentedComment #4
avpadernoComment #5
avpadernoPAReview still reports some of the same errors it reported. The version, project, and datestamp keys were removed in a commit, but re-added in another one.
Comment #6
avpadernoAlso, from where are you copying this data, and why?
Comment #7
avpadernoWhen the Markdown module doesn't exist, the content of the file still need to be sanitized.
Data are sanitized when output, not when being handled.
search_data()doesn't throw any exception, and that would be a bad way to handle them, though.The module isn't much complex to be used as application, considering that
hook_help()is copied from another project and the content of the .info file has been copied from a different project. What left is a function that simply geta the output of a Drupal core function and returns it as JSON.Comment #8
avpadernoThis project is too short to approve you as vetted user. Everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can opt into security coverage for this project for you.
Comment #9
avpadernoKeep also in mind that new projects must wait 10 days before opting into security advisory coverage.
Comment #10
avpadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.
Comment #11
avpaderno