Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Aug 2013 at 18:26 UTC
Updated:
10 Nov 2013 at 05:26 UTC
Jump to comment: Most recent
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxgrantdobbe2056027git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
Steven Brown commentedI have visited http://pareview.sh/pareview/httpgitdrupalorgsandboxgrantdobbe2056027git and fixed all the errors that were presented.
Comment #3
serm commentedHi,
1. Please add commerce_shipstation.install file and add it hook_uninstall for remove all variables after removing the module
2. Rename README.md to README.txt
Comment #4
Steven Brown commentedI have fixed the issues stated in comment #3.
Comment #5
asherry commented@FatGuyLaughing, don't forget to delete your master branch. You can do this with 'git branch -d master', or 'git branch -d -r master'. This will help in the review as it's confusing when you first clone the repository, it looks like changes weren't made.
The other thing I would do is make sure your default repository is 7.x-1.x-dev, so that there is no confusion for the actual reviewer.
Comment #6
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.