I have completed the module to a fully functional state and have uploaded it as a Drupal Sandbox project seeing that this is my first project. Hopefully I can get it accepted as a full module.

This modules utilizes the Flag (https://drupal.org/project/flag) and Private Message (https://drupal.org/project/Privatemsg) modules to create an Inquiry Cart solution.

The module works by flagging nodes with the Inquiry Cart flag which will addd the nodes to the Inquiry Cart page where users can remove items or move on to the page to submit the inquiries.

The user will be then have a final option to select which items to inquiry about (All items are selected by default) and enter a subject and message body that will be sent to each node's author with a reference to the node attached to the end of the message body.

I decided to develope this moduke because I was unable to find a similar solution. This solution is similar to what is available on www.alibaba.com and www.ec21.com.

The sandbox project is located at: https://drupal.org/sandbox/doors/2021089'
Git repository: git clone --branch 7.x-1.x doors@git.drupal.org:sandbox/doors/2021089.git

CommentFileSizeAuthor
Configuration Page.png27.18 KBdoors
Submit Inquiries Page.png29.3 KBdoors
Inquiry Cart Page.png20.87 KBdoors
Menu Item.png15.51 KBdoors

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxdoors2021089git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Issue summary: View changes

Changed Git Clone with Git Repository

doors’s picture

doors commented

I have made all changes that Code Sniffer has suggested except one warning that i believe should not be an issue.

This warning states that: 74 | WARNING | Only string literals should be passed to t() where possible.

The code that throws this warning is used to dynamically generate the title with the amount of items in the cart shown in bracket:

$records_count = count($options);
$title = 'Inquiry Cart (' . $records_count . ')');
return t($title);
doors’s picture

doors commented
Status: Needs work » Needs review

If someone can give me a better way to implement the code below that would be good but for me this is alright.

$records_count = count($options);
$title = 'Inquiry Cart (' . $records_count . ')');
return t($title);
swim’s picture

swim commented

Hey doors,

Replying to your question above first, t function could be implemented as such;

$records_count = count($options);
$title = t('Inquiry Cart') . '(' . $records_count . ')';
return $title;

Messy but fits with the coding convention wrapping only the text.

I'm sorry but I can't really provide a proper review as I'm unfamiliar with the modules you are integrating into, flags & PM.

File pm_inquiry_cart.module, line 170.
Your building your link in an odd way, have a look at function l.
This also goes for line 118 & 94 of the same file.

You still have a master branch in your repository this can be removed.

bhobbs-chitika’s picture

bhobbs-chitika commented
Status: Needs review » Needs work

Hello,

The t function could also be implemented as,

$title = t("Inquiry Cart(@count)", array => '@count' => $records_count);

refer to https://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/t/7

I couldn't find any major flaws with the code. Great job.

I agree with hapax that you should look into l() function, https://api.drupal.org/api/drupal/includes!common.inc/function/l/7.

For instance on line 118, I think you can do something like 

l(t('Click to Submit Your Inquiries', url($url)))
PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Issue summary: View changes

I included the wrong Git Repository. Instead of the 7.x-1.x branch i had included the Master branch which did not have the updated code.