[D7] Random alpha numeric token

README is good, project page a bit sparse but describes the module.

A few comments and questions:

Master branch

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588. Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Manual review

• The module is very short and simple. Have you considered submitting it as a patch to Token module instead of creating a new module? Such functionality has already been discussed and included albeit in a simpler form.
• The character limits in the description (max 32) does not match the code (max 36).
• How about using the range() function to simplify the candidate letters and numbers?
• The examples are a bit misleading as the token cannot generate uppercase characters (nitpicking, I know)

It would be nice to see this functionality implemented one way or the other.

Cheers!

1. The git URL is http://git.drupal.org/sandbox/takah/1879162.git

2. The repository still has a master branch. This needs to be removed.

3. There are 92 lines of code (including comments), and 2 functions. According to the guidelines at http://drupal.org/node/1587704, a minimum of 120 lines and 5 functions are required for approval. This is a pretty simple module, and I don't know what could be added/expanded to meet these requirements.

4. No security issues found

5. Documentation looks good

6. Coding standards look good. http://ventral.org/pareview/httpgitdrupalorgsandboxtakah1879162git

7. If the given length is outside of the coded range (5-35), 8 is assumed. Perhaps set it to a min or max instead. For example, If <4, use 4. If >36, use 36.

All in all, a pretty simple, straightforward module. Just a few things to work on for approval.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Hi takah,

This is a nice (very) little module. Elegantly implemented, but I am also wondering if it is long enough to qualify you for full project permissions. But that's for others to decide... I've also submitted a little module, so I live in a glass house, I guess. But, you do look like you're capable of writing very nice code. Is this the project you want to submit?

If so, and you need more lines, you might offer another token that generates alpha only instead of alphanumeric. Numeric only is provided by token module standard I see. Or you could go all crazy and allow folks to provide a set of their own chosen characters to be used in the random string. That plus a settings form for it would pad out your module. Somehow, I don't think this is what you want to spend your time doing though, mostly because it would be useful to only .00034%* of the population.

On to the actual review... what there is of it.

Nit picking ....

I would be helpful if your git clone statement included the desired module folder name

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/takah/1879162.git random_alpha_numeric_token
instead of
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/takah/1879162.git

otherwise the folder name becomes 1879162...

Crazy nit picking....
I believe alphanumeric is one word?

Oh, and the module works, have tested it. I'm setting this to reviewed and tested, because it seems you need some opinion / attention from higher up on the meta issues above.

* did you know that 63% of all statistics are just made up?

Hi.
Unfortunately this project is way too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Please also consider providing the functionality as a patch to the Token-module instead of publishing it as a single project. I'm sure the maintainer of Token would be happy about your contribution.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Hey, what happened to the code? did it get to token?

fixed the URI of the git repository.

I came across this functionality.
Git repo cloned, module enabled and working as promised.
Easy, nice and clean.

Many thanks.

Serves its purpose. Simple and very useful! Thanks