1. This module fills the void that is left after the Deprecation of the Facebook Share button by Facebook.com. This module differs from the Facebook Share module, in that that module is no longer seems to be actively maintained, and makes use of the old facebook share functionality in order to run, which is no longer applicable due to the deprecation of the code. This module, instead, builds the facebook share button by hand, and stores the contents returned by the facebook api in the database in order to run quickly. This module also allows for the content to be switched between the Box Count display, Horizontal Count, and the plain button.
4. The link to my project is Facebook Share Button
5. This is for Drupal 6

Comments

amitgoyal’s picture

amitgoyal commented

Firstly, thank you for this module, will really ease out things in many projects.

Review of your Module

Link to your GIT Repo is missing, follow instruction here to create a good project application - http://drupal.org/node/1011698

You are working on Master branch, you should be working on version specific branch, more instruction here - http://drupal.org/node/1127732

.module file
line 279 - blank print - print '';

Tpl file
You can remove dsm.

Automated Review - many issues pointed in automated review, please get them sorted - http://ventral.org/pareview/httpgitdrupalorgsandboxxrampage161712852git

amitgoyal’s picture

amitgoyal commented
Status: Needs review » Needs work

Updating status to Needs Work.

patrickd’s picture

patrickd commented
Status: Needs work » Closed (won't fix)

That the old module seems to be unmaintained is absolutely no reason to create a duplicating one.

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).