Outbrain

Hi,

I found few issues in your module while doing manual review
1) Please remove your commented code from the files. This should never be done.
2) You also haven't followed indentation at various places. Make sure each of your code line is follows indentation as per standards. You can refer this for above.
3) Make sure each of your file ends with an new line.
4) You can remove $Id$ as its no longer necessary.
5) You have used js onload function in your js file. I would suggest jquery's document.ready function.
6) Also README.txt is too small with content. Make sure to write and guide how the module works. Also project description is also not enough.

Also make sure to fix your report issues here http://ventral.org/pareview/httpgitdrupalorgsandboxeyalev1688154git

Hi,

I installed your module but don't see any links pointing to your configuration page. You might want to add a link somewhere. You could add a configure line to your module's .info file, or do what's needed to get your menu item to show up on the config page (http://drupal.stackexchange.com/questions/1757/how-to-add-module-to-admi... might help), or both.

Here are another few issues I'm seeing on a quick readthrough of the code:

1. Line 49 - #description should be wrapped in t() I think
2. In your config form, you check for the outbrain_node_types variable, and default to 'blog', but in outbrain_node_view you do the same check but default to 'article'. Should these be consistent?
3. I'm not sure what the purpose of all this logic here is:

     // Get recommendation mode and rater mode.
     $outbrain_rec_mode   = variable_get("outbrain_rec_mode", NULL);
     $outbrain_rater_mode = variable_get("outbrain_rater_mode", NULL);
     if (empty($outbrain_rec_mode) || empty($outbrain_rater_mode)) {
       $outbrain_rater_mode = 'none';
       $outbrain_rec_mode = 'strip';
       variable_set('outbrain_rec_mode', $outbrain_rec_mode);
       variable_set('outbrain_rater_mode', $outbrain_rater_mode);
     }
   

   It doesn't seem like there's anywhere that these variables could be set to anything other than the defaults, so why use variables?

4.   if (!isset($installation_time_string) || (isset($installation_time_string) &&  empty($installation_time_string))) {
   

   I think this can be simplified to:

     if (empty($installation_time_string)) {
   

5.   $count_options = array(
       1 => '1',
       2 => '2',
       3 => '3',
       4 => '4',
       5 => '5',
       6 => '6',
       7 => '7',
       8 => '8',
       9 => '9',
       10 => '10',
     );
   

   This can be simplified to:

      $count_options = drupal_map_assoc(range(1, 10));
   

6. In the same block of code, you've defined $size_options = array(); but then don't use this variable anywhere else.
7. The module ends with a comment block about implementing hook_block, but the following code is just sitting out in the open, not implementing a hook. I'm guessing this is something you want to run on every page load, but even so, isn't there a hook it should go into?
8. For your javascript, you might want to take a read through http://drupal.org/node/756722. I think your javascript is more likely to play better with other modules if you use Drupal.behaviors, and try encapsulating your code a little more. I'm also not sure if there was a good reason to avoid using jQuery, which is built-in to Drupal, but I think there's no reason to reinvent the wheel. Why define outbrain_$() when you can do this?

   (function ($) {
     // All your code here
   })(jQuery);
   

Overall I think the code could still use a bit tightening up, especially since it looks like there's remnants sitting around that you maybe forgot to delete. And I'm not an expert but I think there are definitely some more Drupal ways to implement your javascript, and considering this module is mostly javascript, it might be worth taking the time to read up on.

Outbrain integration module developed by jarrodirwin for Dennis Publishing is now contributed to the community and available here: http://drupal.org/project/outbrain

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

On the Outbrain script below:

What to replace in DROP_PERMALINK_HERE?

Help is very much appreciated. I am integrating it in drupal 7 site.

Thanks,
Rene

Here is the code...

<div data-src="DROP_PERMALINK_HERE" class="OUTBRAIN" ></div>
<script type="text/javascript">(function(){window.OB_platformType=8;window.OB_langJS="http://widgets.outbrain.com/lang_en.js";window.OBITm="1370639749351";window.OB_recMode="brn_strip";var ob=document.createElement("script");ob.type="text/javascript";ob.async=true;ob.src="http"+("https:"===document.location.protocol?"s":"")+"://widgets.outbrain.com/outbrainLT.js";var h=document.getElementsByTagName("script")[0];h.parentNode.insertBefore(ob,h);})();</script>

Perhaps best to post the issue within the project page issue queue. -- > http://drupal.org/project/outbrain

Update