Category: External Integration
Status: needs review
Title: Google Calendar Node synchronization
Drupal version: 6.x (nodeapi changes would require changes for a D7 version)
Drupal GIT repo:
git clone --branch master http://git.drupal.org/sandbox/ianmarcinkowski/1460474.git google_calendar_node_synchronization_
Sandbox Project page: http://drupal.org/sandbox/ianmarcinkowski/1460474

Description:

This module is designed to sync information about your nodes to a Google calendar. There are site-wide settings for your Google Calendar account information and node-specific configuration settings for exact values such as dates, timezones, event location and event information. Each node type can have different field settings to suit your needs.

I have attached a few screenshots of global and node configuration pages.

Global configuration settings allow the user to specify which content types on their Drupal install they wish to use the module with. Only selected node types will see Google Calendar settings on their /admin/content/node-type/type-name page or be included in node processing for synchronization.

The module hooks in to nodeapi presave and delete to do most of the work.

CommentFileSizeAuthor
nodesettings3.png48.38 KBianmarcinkowski
nodesettings2.png46.69 KBianmarcinkowski
nodesettings1.png49.34 KBianmarcinkowski
globalsettings1.png34.89 KBianmarcinkowski

Comments

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Status: Active » Needs review

Application Workflow requires that new modules be 'Needing Review'

ianmarcinkowski’s picture

ianmarcinkowski commented

I just noticed that the default git project folder is google_calendar_node_synchronization_. The intended project name is gcal_nodes.

If checking out of git clone into a directory named gcal_nodes:
git clone --branch master http://git.drupal.org/sandbox/ianmarcinkowski/1460474.git gcal_nodes

This is my first module, so I didn't think about that.

patrickd’s picture

patrickd commented
Status: Needs review » Needs work

welcome,

the current name doesn't matter, if you get full project access later you can specify the correct project short name.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
(This has to be fixed before you can switch back to "needs review")

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxianmarcinkowski146047...

You can also get a review bonus and we will come back to your application sooner.

ianmarcinkowski’s picture

ianmarcinkowski commented

I have created a 6.x-1.x branch and pushed that to my repo, as well as a 6.x-1.x-dev branch to work on the requested changes.

As far as I can tell, all of the formatting changes from the automated code review were regarding the Zend framework codebase that was included in the project. I am re-running a code review now on my changes.

I see that there are some new issues with my code. I will begin work on these.

Users who do not have the Zend framework in the PHP PATH on their server will need to install Libraries API and the Drupal Zend Framework modules to get this to work. I have not included these as dependencies because some server setups will not require it.

patrickd’s picture

patrickd commented

You should not include foreign libraries in your module as eg. two modules doing the same could mess everything up.

Rather then doing this you should implement hook_requirements and check whether its needed to install the drupal zend framework or not.

3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

ianmarcinkowski’s picture

ianmarcinkowski commented

Okay, that's a cool approach. I'll do that.

Thanks.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Added Sandbox project page