This is a starterkit theme for the Omega base theme. It basically overwrites the Omega default 960 grids with those sizes from the popular 978.gs grid.
The starterkit theme is meant for Drupal 7.

Sandbox url: http://drupal.org/sandbox/ironkiat/1430056

git clone --branch master ironkiat@git.drupal.org:sandbox/ironkiat/1430056.git omega_978_gs_starterkit_theme
cd omega_978_gs_starterkit_theme

Comments

nick_schuch’s picture

nick_schuch commented
Status: Needs review » Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

  • README.txt is missing, see the guidelines for in-project documentation.
  • The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags
    ./template.php
  • Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
    ./css/pixelonionkit-alpha-default-narrow.css:                ASCII C program text, with no line terminators
./css/pixelonionkit-alpha-default.css:                       ASCII C program text, with no line terminators
./css/pixelonionkit-978gs-default.css:                       ASCII C program text, with no line terminators
./css/pixelonionkit-alpha-default-wide.css:                  ASCII C program text, with no line terminators
./css/pixelonionkit-978gs-default-narrow.css:                ASCII C program text, with no line terminators
./css/pixelonionkit-978gs-default-wide.css:                  ASCII C program text, with no line terminators
./css/pixelonionkit-alpha-default-normal.css:                ASCII C program text, with no line terminators
./css/pixelonionkit-978gs-default-normal.css:                ASCII C program text, with no line terminators
  • Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.


FILE: ...-pareview/sites/all/modules/pareview_temp/test_candidate/css/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 11 WARNING(S) AFFECTING 12 LINE(S)
--------------------------------------------------------------------------------
  1 | WARNING | Line exceeds 80 characters; contains 90 characters
  2 | WARNING | Line exceeds 80 characters; contains 81 characters
  3 | WARNING | Line exceeds 80 characters; contains 88 characters
  4 | WARNING | Line exceeds 80 characters; contains 89 characters
  5 | WARNING | Line exceeds 80 characters; contains 89 characters
  6 | WARNING | Line exceeds 80 characters; contains 89 characters
  8 | WARNING | Line exceeds 80 characters; contains 90 characters
 10 | WARNING | Line exceeds 80 characters; contains 90 characters
 12 | WARNING | Line exceeds 80 characters; contains 90 characters
 19 | WARNING | Line exceeds 80 characters; contains 90 characters
 21 | WARNING | Line exceeds 80 characters; contains 90 characters
 23 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: .../sites/all/modules/pareview_temp/test_candidate/css/delta/frontpage.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------


FILE: ...est_candidate/css/grid/978gs_default/narrow/978gs-default-narrow-12.css
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  19 | ERROR | Expected exactly one new line before closing brace of class
     |       | definition
 309 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...est_candidate/css/grid/978gs_default/normal/978gs-default-normal-12.css
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  19 | ERROR | Expected exactly one new line before closing brace of class
     |       | definition
 309 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...mp/test_candidate/css/grid/978gs_default/wide/978gs-default-wide-12.css
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  19 | ERROR | Expected exactly one new line before closing brace of class
     |       | definition
 309 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...pareview_temp/test_candidate/css/pixelonionkit-978gs-default-narrow.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...pareview_temp/test_candidate/css/pixelonionkit-978gs-default-normal.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...s/pareview_temp/test_candidate/css/pixelonionkit-978gs-default-wide.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...odules/pareview_temp/test_candidate/css/pixelonionkit-978gs-default.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...pareview_temp/test_candidate/css/pixelonionkit-alpha-default-narrow.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...pareview_temp/test_candidate/css/pixelonionkit-alpha-default-normal.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...s/pareview_temp/test_candidate/css/pixelonionkit-alpha-default-wide.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...odules/pareview_temp/test_candidate/css/pixelonionkit-alpha-default.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/pixelonionkit.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 404 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...ew/sites/all/modules/pareview_temp/test_candidate/preprocess/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 14 WARNING(S) AFFECTING 15 LINE(S)
--------------------------------------------------------------------------------
  1 | WARNING | Line exceeds 80 characters; contains 90 characters
  2 | WARNING | Line exceeds 80 characters; contains 81 characters
  3 | WARNING | Line exceeds 80 characters; contains 88 characters
  4 | WARNING | Line exceeds 80 characters; contains 89 characters
  5 | WARNING | Line exceeds 80 characters; contains 89 characters
  6 | WARNING | Line exceeds 80 characters; contains 89 characters
  8 | WARNING | Line exceeds 80 characters; contains 90 characters
 10 | WARNING | Line exceeds 80 characters; contains 90 characters
 12 | WARNING | Line exceeds 80 characters; contains 90 characters
 19 | WARNING | Line exceeds 80 characters; contains 90 characters
 21 | WARNING | Line exceeds 80 characters; contains 90 characters
 23 | WARNING | Line exceeds 80 characters; contains 88 characters
 33 | WARNING | Line exceeds 80 characters; contains 89 characters
 34 | WARNING | Line exceeds 80 characters; contains 90 characters
 39 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...all/modules/pareview_temp/test_candidate/preprocess/preprocess-html.inc
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | You must use "/**" style comments for a file comment
 8 | ERROR | Whitespace found at end of line
 9 | ERROR | Files must end in a single new line character
 9 | ERROR | The final ?> should be omitted from all code files
--------------------------------------------------------------------------------


FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/process/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 14 WARNING(S) AFFECTING 15 LINE(S)
--------------------------------------------------------------------------------
  1 | WARNING | Line exceeds 80 characters; contains 90 characters
  2 | WARNING | Line exceeds 80 characters; contains 81 characters
  3 | WARNING | Line exceeds 80 characters; contains 88 characters
  4 | WARNING | Line exceeds 80 characters; contains 89 characters
  5 | WARNING | Line exceeds 80 characters; contains 89 characters
  6 | WARNING | Line exceeds 80 characters; contains 89 characters
  8 | WARNING | Line exceeds 80 characters; contains 90 characters
 10 | WARNING | Line exceeds 80 characters; contains 90 characters
 12 | WARNING | Line exceeds 80 characters; contains 90 characters
 19 | WARNING | Line exceeds 80 characters; contains 90 characters
 21 | WARNING | Line exceeds 80 characters; contains 90 characters
 23 | WARNING | Line exceeds 80 characters; contains 85 characters
 33 | WARNING | Line exceeds 80 characters; contains 86 characters
 34 | WARNING | Line exceeds 80 characters; contains 87 characters
 39 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/template.php
--------------------------------------------------------------------------------
FOUND 10 ERROR(S) AND 6 WARNING(S) AFFECTING 10 LINE(S)
--------------------------------------------------------------------------------
  5 | WARNING | Line exceeds 80 characters; contains 86 characters
  6 | WARNING | Line exceeds 80 characters; contains 93 characters
  8 | ERROR   | Whitespace found at end of line
  9 | WARNING | Line exceeds 80 characters; contains 93 characters
 10 | WARNING | Line exceeds 80 characters; contains 97 characters
 14 | ERROR   | Missing function doc comment
 16 | WARNING | Line exceeds 80 characters; contains 89 characters
 16 | ERROR   | Comments may not appear after statements.
 17 | WARNING | Line exceeds 80 characters; contains 107 characters
 17 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
    |         | question marks
 17 | ERROR   | There must be no blank line following an inline comment
 17 | ERROR   | Comments may not appear after statements.
 19 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 0
 19 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
    |         | question marks
 25 | ERROR   | Files must end in a single new line character
 25 | ERROR   | The final ?> should be omitted from all code files
--------------------------------------------------------------------------------


FILE: ...iew/sites/all/modules/pareview_temp/test_candidate/templates/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 13 WARNING(S) AFFECTING 14 LINE(S)
--------------------------------------------------------------------------------
  1 | WARNING | Line exceeds 80 characters; contains 90 characters
  2 | WARNING | Line exceeds 80 characters; contains 81 characters
  3 | WARNING | Line exceeds 80 characters; contains 88 characters
  4 | WARNING | Line exceeds 80 characters; contains 89 characters
  5 | WARNING | Line exceeds 80 characters; contains 89 characters
  6 | WARNING | Line exceeds 80 characters; contains 89 characters
  8 | WARNING | Line exceeds 80 characters; contains 90 characters
 10 | WARNING | Line exceeds 80 characters; contains 90 characters
 12 | WARNING | Line exceeds 80 characters; contains 90 characters
 19 | WARNING | Line exceeds 80 characters; contains 90 characters
 21 | WARNING | Line exceeds 80 characters; contains 89 characters
 22 | WARNING | Line exceeds 80 characters; contains 88 characters
 25 | WARNING | Line exceeds 80 characters; contains 87 characters
 26 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.