JQGRID

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

includes/jqgrid.views.inc in jqgrid.info: It's only necessary to declare files[] if they declare a class or interface.
Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
./js/jqgrid.admin.js: ASCII text, with no line terminators

Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

sites/all/modules/pareview_temp/test_candidate/jqgrid.module:
+6: [minor] put a space between the asterisk and the comment text
+17: [minor] put a space between the asterisk and the comment text
+153: [minor] put a space between the asterisk and the comment text

Status Messages:
Coder found 1 projects, 1 files, 3 minor warnings, 0 warnings were flagged to be ignored

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 11 WARNING(S) AFFECTING 11 LINE(S)
--------------------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 86 characters
3 | WARNING | Line exceeds 80 characters; contains 86 characters
14 | WARNING | Line exceeds 80 characters; contains 86 characters
16 | WARNING | Line exceeds 80 characters; contains 86 characters
24 | WARNING | Line exceeds 80 characters; contains 86 characters
26 | WARNING | Line exceeds 80 characters; contains 86 characters
39 | WARNING | Line exceeds 80 characters; contains 86 characters
41 | WARNING | Line exceeds 80 characters; contains 86 characters
49 | WARNING | Line exceeds 80 characters; contains 86 characters
51 | WARNING | Line exceeds 80 characters; contains 86 characters
54 | WARNING | Line exceeds 80 characters; contains 120 characters
54 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...-pareview/sites/all/modules/pareview_temp/test_candidate/css/jqgrid.css
--------------------------------------------------------------------------------
FOUND 20 ERROR(S) AFFECTING 20 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Spaces must be used to indent lines; tabs are not allowed
3 | ERROR | Spaces must be used to indent lines; tabs are not allowed
4 | ERROR | Spaces must be used to indent lines; tabs are not allowed
5 | ERROR | Spaces must be used to indent lines; tabs are not allowed
6 | ERROR | Spaces must be used to indent lines; tabs are not allowed
7 | ERROR | Spaces must be used to indent lines; tabs are not allowed
8 | ERROR | Spaces must be used to indent lines; tabs are not allowed
9 | ERROR | Spaces must be used to indent lines; tabs are not allowed
13 | ERROR | Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
25 | ERROR | Spaces must be used to indent lines; tabs are not allowed
26 | ERROR | Spaces must be used to indent lines; tabs are not allowed
27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
28 | ERROR | Spaces must be used to indent lines; tabs are not allowed
29 | ERROR | Spaces must be used to indent lines; tabs are not allowed
30 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: .../all/modules/pareview_temp/test_candidate/includes/jqgrid.callbacks.inc
--------------------------------------------------------------------------------
FOUND 13 ERROR(S) AND 1 WARNING(S) AFFECTING 11 LINE(S)
--------------------------------------------------------------------------------
8 | ERROR | Missing function doc comment
18 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
20 | ERROR | Whitespace found at end of line
22 | ERROR | No space before comment text; expected "// CHECH FIELD
| | PERMISSION" but found "//CHECH FIELD PERMISSION"
22 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
22 | ERROR | There must be no blank line following an inline comment
23 | ERROR | Whitespace found at end of line
28 | ERROR | Whitespace found at end of line
32 | ERROR | Whitespace found at end of line
43 | ERROR | No space before comment text; expected "// TODO" but found
| | "//TODO"
43 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
56 | WARNING | A comma should follow the last multiline array item. Found:
| | $return_value
62 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
70 | ERROR | More than 2 empty lines are not allowed
--------------------------------------------------------------------------------

FILE: ...sites/all/modules/pareview_temp/test_candidate/includes/jqgrid.json.inc
--------------------------------------------------------------------------------
FOUND 55 ERROR(S) AFFECTING 39 LINE(S)
--------------------------------------------------------------------------------
8 | ERROR | Missing function doc comment
10 | ERROR | Inline comments must start with a capital letter
10 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
12 | ERROR | Inline comments must start with a capital letter
12 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
15 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
19 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
22 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
36 | ERROR | Whitespace found at end of line
37 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
46 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
53 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
57 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
70 | ERROR | Whitespace found at end of line
71 | ERROR | Inline comments must start with a capital letter
71 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
75 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
77 | ERROR | Whitespace found at end of line
78 | ERROR | Expected 0 spaces after opening bracket; 1 found
78 | ERROR | Expected 0 spaces before closing bracket; 1 found
79 | ERROR | An operator statement must be followed by a single space
79 | ERROR | There must be a single space before an operator statement
80 | ERROR | Whitespace found at end of line
84 | ERROR | Inline control structures are not allowed
84 | ERROR | An operator statement must be followed by a single space
84 | ERROR | There must be a single space before an operator statement
85 | ERROR | An operator statement must be followed by a single space
85 | ERROR | There must be a single space before an operator statement
86 | ERROR | Inline control structures are not allowed
86 | ERROR | An operator statement must be followed by a single space
86 | ERROR | There must be a single space before an operator statement
88 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
90 | ERROR | Comments may not appear after statements.
90 | ERROR | Inline comments must start with a capital letter
91 | ERROR | Comments may not appear after statements.
92 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
92 | ERROR | Comments may not appear after statements.
94 | ERROR | Whitespace found at end of line
113 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
114 | ERROR | You must use "/**" style comments for a function comment
116 | ERROR | Inline control structures are not allowed
117 | ERROR | Expected 0 spaces after opening bracket; 1 found
117 | ERROR | Expected 0 spaces before closing bracket; 1 found
118 | ERROR | Inline control structures are not allowed
122 | ERROR | Inline control structures are not allowed
123 | ERROR | Inline control structures are not allowed
125 | ERROR | Inline control structures are not allowed
131 | ERROR | Missing function doc comment
133 | ERROR | Space found after opening bracket of FOR loop
133 | ERROR | Space found before closing bracket of FOR loop
134 | ERROR | Expected 0 spaces after opening bracket; 1 found
134 | ERROR | Expected 0 spaces before closing bracket; 1 found
134 | ERROR | Whitespace found at end of line
135 | ERROR | Whitespace found at end of line
141 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...ites/all/modules/pareview_temp/test_candidate/includes/jqgrid.views.inc
--------------------------------------------------------------------------------
FOUND 21 ERROR(S) AND 7 WARNING(S) AFFECTING 27 LINE(S)
--------------------------------------------------------------------------------
9 | WARNING | Format should be * Implements hook_foo().
21 | WARNING | A comma should follow the last multiline array item. Found: ''
38 | WARNING | A comma should follow the last multiline array item. Found:
| | 'normal'
39 | WARNING | A comma should follow the last multiline array item. Found: )
40 | WARNING | A comma should follow the last multiline array item. Found: )
61 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
63 | ERROR | Whitespace found at end of line
64 | ERROR | Inline comments must start with a capital letter
64 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
66 | ERROR | Whitespace found at end of line
67 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
74 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
77 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
81 | ERROR | Whitespace found at end of line
82 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
83 | ERROR | Whitespace found at end of line
87 | ERROR | Whitespace found at end of line
89 | ERROR | Whitespace found at end of line
93 | ERROR | Inline comments must start with a capital letter
94 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
95 | ERROR | Whitespace found at end of line
100 | ERROR | Whitespace found at end of line
104 | ERROR | Whitespace found at end of line
133 | WARNING | Line exceeds 80 characters; contains 81 characters
134 | WARNING | Line exceeds 80 characters; contains 85 characters
159 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
162 | ERROR | Whitespace found at end of line
168 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...l/modules/pareview_temp/test_candidate/includes/jqgrid_views_plugin.inc
--------------------------------------------------------------------------------
FOUND 34 ERROR(S) AND 23 WARNING(S) AFFECTING 50 LINE(S)
--------------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
13 | ERROR | Class property $locked_fields should use lowerCamel naming
| | without underscores
15 | ERROR | Missing function doc comment
18 | ERROR | Expected 0 spaces after opening bracket; 1 found
18 | ERROR | Expected 0 spaces before closing bracket; 1 found
23 | WARNING | Line exceeds 80 characters; contains 90 characters
23 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
31 | ERROR | Method name "jqgrid_views_plugin::option_definition" is not in
| | lowerCamel format, it must not contain underscores
61 | ERROR | Missing parameter type at position 1
62 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
64 | ERROR | Missing parameter type at position 2
65 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
70 | ERROR | Method name "jqgrid_views_plugin::sanitize_columns" is not in
| | lowerCamel format, it must not contain underscores
95 | ERROR | Method name "jqgrid_views_plugin::options_form" is not in
| | lowerCamel format, it must not contain underscores
98 | WARNING | A comma should follow the last multiline array item. Found:
| | '/js/jqgrid.admin.js'
110 | WARNING | A comma should follow the last multiline array item. Found:
| | ''
114 | WARNING | Line exceeds 80 characters; contains 95 characters
114 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
116 | ERROR | Whitespace found at end of line
118 | ERROR | Inline comments must start with a capital letter
120 | ERROR | Whitespace found at end of line
121 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
123 | WARNING | A comma should follow the last multiline array item. Found: ]
125 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
130 | WARNING | A comma should follow the last multiline array item. Found: 10
133 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
146 | ERROR | Expected 0 spaces after opening bracket; 1 found
146 | ERROR | Expected 0 spaces before closing bracket; 1 found
164 | ERROR | Inline comments must start with a capital letter
184 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
188 | WARNING | A comma should follow the last multiline array item. Found: 10
192 | ERROR | No space before comment text; expected "// TODO" but found
| | "//TODO"
195 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
199 | WARNING | A comma should follow the last multiline array item. Found: 10
204 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
205 | ERROR | There must be a single space before an operator statement
216 | WARNING | A comma should follow the last multiline array item. Found: )
224 | WARNING | A comma should follow the last multiline array item. Found:
| | 'height'
225 | WARNING | A comma should follow the last multiline array item. Found: )
233 | WARNING | A comma should follow the last multiline array item. Found:
| | 'width'
234 | WARNING | A comma should follow the last multiline array item. Found: )
242 | WARNING | A comma should follow the last multiline array item. Found:
| | 'rowNum'
243 | WARNING | A comma should follow the last multiline array item. Found: )
248 | WARNING | A comma should follow the last multiline array item. Found: )
256 | WARNING | A comma should follow the last multiline array item. Found:
| | 'scroll'
257 | WARNING | A comma should follow the last multiline array item. Found: )
265 | WARNING | A comma should follow the last multiline array item. Found:
| | 'sortable'
266 | WARNING | A comma should follow the last multiline array item. Found: )
274 | WARNING | A comma should follow the last multiline array item. Found:
| | 'filterToolbar'
275 | WARNING | A comma should follow the last multiline array item. Found: )
281 | ERROR | You must use "/**" style comments for a function comment
281 | ERROR | Method name "jqgrid_views_plugin::field_is_editable" is not in
| | lowerCamel format, it must not contain underscores
289 | ERROR | You must use "/**" style comments for a function comment
290 | WARNING | Line exceeds 80 characters; contains 86 characters
290 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
293 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...l-7-pareview/sites/all/modules/pareview_temp/test_candidate/jqgrid.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
13 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...-pareview/sites/all/modules/pareview_temp/test_candidate/jqgrid.install
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 17 WARNING(S) AFFECTING 18 LINE(S)
--------------------------------------------------------------------------------
9 | WARNING | Format should be * Implements hook_foo().
24 | WARNING | A comma should follow the last multiline array item. Found: ]
25 | WARNING | A comma should follow the last multiline array item. Found: )
34 | WARNING | A comma should follow the last multiline array item. Found: ]
42 | WARNING | Format should be * Implements hook_foo().
52 | WARNING | A comma should follow the last multiline array item. Found:
| | 'The users UID.'
59 | WARNING | A comma should follow the last multiline array item. Found:
| | 'The unique name of the view. May only be alphanumeric
| | characters plus underscores.'
66 | WARNING | A comma should follow the last multiline array item. Found: 'An
| | identifier for this display; usually generated from the
| | display_plugin, so should be something like page or page_1 or
| | block_2, etc.'
72 | WARNING | A comma should follow the last multiline array item. Found: 'A
| | serialized array of view settings.'
73 | WARNING | A comma should follow the last multiline array item. Found: )
77 | WARNING | A comma should follow the last multiline array item. Found:
| | 'view_name'
83 | WARNING | A comma should follow the last multiline array item. Found:
| | 'display_id'
84 | WARNING | A comma should follow the last multiline array item. Found: )
89 | WARNING | A comma should follow the last multiline array item. Found:
| | 'view_name'
90 | WARNING | A comma should follow the last multiline array item. Found: )
91 | WARNING | A comma should follow the last multiline array item. Found: )
92 | WARNING | A comma should follow the last multiline array item. Found: )
95 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...7-pareview/sites/all/modules/pareview_temp/test_candidate/jqgrid.module
--------------------------------------------------------------------------------
FOUND 37 ERROR(S) AND 27 WARNING(S) AFFECTING 53 LINE(S)
--------------------------------------------------------------------------------
2 | WARNING | Line exceeds 80 characters; contains 94 characters
2 | ERROR | You must use "/**" style comments for a file comment
10 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
13 | WARNING | Line exceeds 80 characters; contains 94 characters
36 | WARNING | Format should be * Implements hook_foo().
39 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
44 | WARNING | A comma should follow the last multiline array item. Found:
| | 'access content'
47 | WARNING | A comma should follow the last multiline array item. Found:
| | 'includes/jqgrid.json.inc'
52 | WARNING | A comma should follow the last multiline array item. Found:
| | 'access content'
55 | WARNING | A comma should follow the last multiline array item. Found:
| | 'includes/jqgrid.callbacks.inc'
61 | WARNING | Format should be * Implements hook_foo().
68 | WARNING | A comma should follow the last multiline array item. Found:
| | '/theme'
73 | WARNING | Format should be * Implements hook_foo().
78 | ERROR | Inline comments must start with a capital letter
78 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
81 | WARNING | A comma should follow the last multiline array item. Found: )
82 | WARNING | A comma should follow the last multiline array item. Found: )
84 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
88 | WARNING | A comma should follow the last multiline array item. Found:
| | 'theme.inc'
89 | WARNING | A comma should follow the last multiline array item. Found: )
94 | WARNING | Format should be * Implements hook_foo().
107 | WARNING | A comma should follow the last multiline array item. Found: )
113 | WARNING | A comma should follow the last multiline array item. Found:
| | 'ui.datepicker'
118 | WARNING | A comma should follow the last multiline array item. Found:
| | 'ui.sortable'
119 | WARNING | A comma should follow the last multiline array item. Found: )
120 | WARNING | A comma should follow the last multiline array item. Found: )
126 | ERROR | More than 2 empty lines are not allowed
127 | ERROR | More than 2 empty lines are not allowed
128 | ERROR | More than 2 empty lines are not allowed
129 | ERROR | More than 2 empty lines are not allowed
130 | ERROR | More than 2 empty lines are not allowed
131 | ERROR | More than 2 empty lines are not allowed
132 | ERROR | More than 2 empty lines are not allowed
133 | ERROR | More than 2 empty lines are not allowed
134 | ERROR | More than 2 empty lines are not allowed
135 | ERROR | More than 2 empty lines are not allowed
136 | ERROR | More than 2 empty lines are not allowed
137 | ERROR | More than 2 empty lines are not allowed
139 | WARNING | Format should be * Implements hook_foo().
139 | ERROR | Extra newline found before function comment short description
141 | ERROR | There must be an empty line before the parameter block
141 | ERROR | Doc comment for var account does not match actual variable
| | name $account at position 1
141 | ERROR | Parameter comment must be on the next line at position 1
145 | WARNING | A comma should follow the last multiline array item. Found:
| | uid
149 | WARNING | Line exceeds 80 characters; contains 94 characters
154 | ERROR | You must use "/**" style comments for a function comment
162 | WARNING | A comma should follow the last multiline array item. Found:
| | $display_id
167 | WARNING | A comma should follow the last multiline array item. Found:
| | 'display_id'
181 | ERROR | Extra newline found before function comment short description
183 | WARNING | Line exceeds 80 characters; contains 87 characters
184 | ERROR | There must be an empty line before the parameter block
184 | ERROR | Doc comment for var $uid does not match actual variable name
| | $conditions at position 1
184 | ERROR | Missing comment for param "$uid" at position 1
185 | ERROR | Doc comment for var $view_name does not match actual variable
| | name $setting at position 2
185 | ERROR | Missing comment for param "$view_name" at position 2
186 | ERROR | Superfluous doc comment at position 3
186 | ERROR | Missing comment for param "$setting" at position 3
194 | WARNING | A comma should follow the last multiline array item. Found:
| | 'settings'
198 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
198 | ERROR | Expected 0 spaces before closing bracket; 1 found
201 | ERROR | Expected "}\nelse {\n"; found "}\n\nelse{\n"
201 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
206 | ERROR | Missing function doc comment
215 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/js/jqgrid.admin.js
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | Files must end in a single new line character
1 | ERROR | Comments may not appear after statements.
--------------------------------------------------------------------------------

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/js/jqgrid.js
--------------------------------------------------------------------------------
FOUND 53 ERROR(S) AFFECTING 53 LINE(S)
--------------------------------------------------------------------------------
3 | ERROR | Spaces must be used to indent lines; tabs are not allowed
5 | ERROR | Spaces must be used to indent lines; tabs are not allowed
7 | ERROR | Spaces must be used to indent lines; tabs are not allowed
8 | ERROR | Spaces must be used to indent lines; tabs are not allowed
9 | ERROR | Spaces must be used to indent lines; tabs are not allowed
10 | ERROR | Spaces must be used to indent lines; tabs are not allowed
11 | ERROR | Spaces must be used to indent lines; tabs are not allowed
12 | ERROR | Spaces must be used to indent lines; tabs are not allowed
13 | ERROR | Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | Spaces must be used to indent lines; tabs are not allowed
15 | ERROR | Spaces must be used to indent lines; tabs are not allowed
16 | ERROR | Spaces must be used to indent lines; tabs are not allowed
17 | ERROR | Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
23 | ERROR | Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | Spaces must be used to indent lines; tabs are not allowed
25 | ERROR | Spaces must be used to indent lines; tabs are not allowed
26 | ERROR | Spaces must be used to indent lines; tabs are not allowed
27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
35 | ERROR | Spaces must be used to indent lines; tabs are not allowed
36 | ERROR | Spaces must be used to indent lines; tabs are not allowed
37 | ERROR | Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | Spaces must be used to indent lines; tabs are not allowed
41 | ERROR | Spaces must be used to indent lines; tabs are not allowed
44 | ERROR | Spaces must be used to indent lines; tabs are not allowed
45 | ERROR | Spaces must be used to indent lines; tabs are not allowed
46 | ERROR | Spaces must be used to indent lines; tabs are not allowed
47 | ERROR | Spaces must be used to indent lines; tabs are not allowed
48 | ERROR | Spaces must be used to indent lines; tabs are not allowed
49 | ERROR | Spaces must be used to indent lines; tabs are not allowed
50 | ERROR | Spaces must be used to indent lines; tabs are not allowed
51 | ERROR | Spaces must be used to indent lines; tabs are not allowed
52 | ERROR | Spaces must be used to indent lines; tabs are not allowed
53 | ERROR | Spaces must be used to indent lines; tabs are not allowed
54 | ERROR | Spaces must be used to indent lines; tabs are not allowed
55 | ERROR | Spaces must be used to indent lines; tabs are not allowed
56 | ERROR | Spaces must be used to indent lines; tabs are not allowed
57 | ERROR | Spaces must be used to indent lines; tabs are not allowed
58 | ERROR | Spaces must be used to indent lines; tabs are not allowed
59 | ERROR | Spaces must be used to indent lines; tabs are not allowed
60 | ERROR | Spaces must be used to indent lines; tabs are not allowed
62 | ERROR | Spaces must be used to indent lines; tabs are not allowed
63 | ERROR | Spaces must be used to indent lines; tabs are not allowed
64 | ERROR | Spaces must be used to indent lines; tabs are not allowed
65 | ERROR | Spaces must be used to indent lines; tabs are not allowed
66 | ERROR | Spaces must be used to indent lines; tabs are not allowed
67 | ERROR | Spaces must be used to indent lines; tabs are not allowed
68 | ERROR | Spaces must be used to indent lines; tabs are not allowed
69 | ERROR | Spaces must be used to indent lines; tabs are not allowed
--------------------------------------------------------------------------------

FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/js/jqgrid.theme.js
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...pareview/sites/all/modules/pareview_temp/test_candidate/theme/theme.inc
--------------------------------------------------------------------------------
FOUND 58 ERROR(S) AND 13 WARNING(S) AFFECTING 51 LINE(S)
--------------------------------------------------------------------------------
8 | ERROR | Missing function doc comment
14 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
22 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
32 | ERROR | No space before comment text; expected "//
| | if(is_array($user_settings = jqgrid_get_settings(array(" but
| | found "//if(is_array($user_settings =
| | jqgrid_get_settings(array("
36 | ERROR | No space before comment text; expected "// )))){" but found
| | "//)))){"
37 | WARNING | Line exceeds 80 characters; contains 95 characters
38 | ERROR | No space before comment text; expected "// }" but found "//}"
38 | ERROR | There must be no blank line following an inline comment
40 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
43 | ERROR | Inline comments must start with a capital letter
43 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
46 | WARNING | Line exceeds 80 characters; contains 86 characters
46 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
46 | ERROR | There must be no blank line following an inline comment
46 | ERROR | Comments may not appear after statements.
48 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
50 | ERROR | Inline comments must start with a capital letter
51 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
62 | ERROR | Whitespace found at end of line
64 | WARNING | Line exceeds 80 characters; contains 85 characters
64 | ERROR | Comments may not appear after statements.
65 | ERROR | Comments may not appear after statements.
66 | WARNING | Line exceeds 80 characters; contains 149 characters
66 | ERROR | Comments may not appear after statements.
73 | ERROR | Expected "}\nelse {\n"; found "}\n\nelse{\n"
78 | WARNING | Line exceeds 80 characters; contains 81 characters
78 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
84 | WARNING | Line exceeds 80 characters; contains 122 characters
86 | WARNING | Line exceeds 80 characters; contains 96 characters
87 | WARNING | Line exceeds 80 characters; contains 209 characters
87 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
87 | ERROR | Comments may not appear after statements.
96 | WARNING | Line exceeds 80 characters; contains 100 characters
96 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
96 | ERROR | Comments may not appear after statements.
106 | ERROR | Inline comments must start with a capital letter
109 | WARNING | Line exceeds 80 characters; contains 95 characters
109 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
112 | WARNING | Line exceeds 80 characters; contains 133 characters
112 | ERROR | Comments may not appear after statements.
112 | ERROR | Inline comments must start with a capital letter
113 | ERROR | Comments may not appear after statements.
114 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
114 | ERROR | There must be no blank line following an inline comment
118 | WARNING | A comma should follow the last multiline array item. Found:
| | 'error'
122 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
124 | WARNING | A comma should follow the last multiline array item. Found:
| | $view
132 | ERROR | There must be an empty line before the parameter block
132 | ERROR | Doc comment for var $view_name does not match actual variable
| | name $variables at position 1
132 | ERROR | Missing comment for param "$view_name" at position 1
139 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
141 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
143 | ERROR | There must be no blank line following an inline comment
145 | ERROR | Inline comments must start with a capital letter
145 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
148 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
152 | ERROR | Inline comments must start with a capital letter
152 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
158 | ERROR | There must be a single space before an operator statement
169 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
172 | ERROR | Whitespace found at end of line
173 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
175 | ERROR | Whitespace found at end of line
179 | ERROR | Whitespace found at end of line
186 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
190 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
193 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
198 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
201 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
204 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
287 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...ll/modules/pareview_temp/test_candidate/theme/views-view-jqgrid.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

@drupalnetworks: please do not post the full output of the review script to the issue queue, as it makes your comment too long. Use attachments instead.

Hi,

Installed the module, and I could not get it to work. I am using Views 7.x-3.0. I download the jqgrid script, get ok on the install on the status report page.

If I create a page view, with the simple settings I get:

I get the message on my page:
    Notice: Undefined property: view::$jqgrid_ajax in jqgrid_views_pre_execute() (line 140 of /srv/www/237/web/sites/all/modules/jqgrid/includes/jqgrid.views.inc).
    Notice: Undefined index: columns in jqgrid_preprocess_views_view_jqgrid() (line 54 of /srv/www/237/web/sites/all/modules/jqgrid/theme/theme.inc).
    Notice: Undefined index: columns in jqgrid_preprocess_views_view_jqgrid() (line 67 of /srv/www/237/web/sites/all/modules/jqgrid/theme/theme.inc).

When I try to edit my View and the settings for jqgrid, I get a message to "select row" (down to the left on the web page) after saving my changes.

Don't forget to set the status to "needs review" if you want to get a review.

Get a review bonus and we will come back to your application sooner.

I used the simple settings in Views, disabled paging and got this error message after creating a page:

Notice: Undefined index: columns in jqgrid_preprocess_views_view_jqgrid() (line 56 of /srv/www/237/web/sites/all/modules/jqgrid/theme/theme.inc).
Notice: Undefined index: columns in jqgrid_preprocess_views_view_jqgrid() (line 69 of /srv/www/237/web/sites/all/modules/jqgrid/theme/theme.inc).

I edit the View, I get some sort of preview, but its messed up, I save and when I goto the page view I get:

Notice: Undefined index: search in jqgrid_preprocess_views_view_jqgrid() (line 56 of /srv/www/237/web/sites/all/modules/jqgrid/theme/theme.inc).
Notice: Undefined index: editable in jqgrid_preprocess_views_view_jqgrid() (line 69 of /srv/www/237/web/sites/all/modules/jqgrid/theme/theme.inc).
Notice: Undefined index: search in jqgrid_preprocess_views_view_jqgrid() (line 56 of /srv/www/237/web/sites/all/modules/jqgrid/theme/theme.inc).
Notice: Undefined index: editable in jqgrid_preprocess_views_view_jqgrid() (line 69 of /srv/www/237/web/sites/all/modules/jqgrid/theme/theme.inc).

Attached my exported View

Activated the plugin, created content, imported the view, saved and goto the the page, and now it works. Now I only need to check if I could do this with my own created view, and check some other things. Good work! I will get back to this soon.

Ok, looks good to me. You have a couple of todos in the code, but the module is pretty complex, and it really seems that you have a good understanding of Drupal standards, security, best practice etc. So it is RTBC for me.

Review of the 7.x-1.x branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

• "print drupal_json_encode($response);": use drupal_json_output() instead.
• jqgrid_json(): why do you need the call to exit()? Same in jqgrid_callback_update().
• "@param unknown_type $value": replace unknown_type with a type that you expect, i.e. string? Also elsewhere.
• jqgrid_strip(): what does this function do? why is it needed? Please explain in the doc block.
• jqgrid_json(): if the view could not be found you should use drupal_not_found() or something like that.
• jqgrid_user_delete(): you don't have to document parameters on hook implementations.
• jqgrid_views_pre_build(): this is a hook implementation and should be documented as such, see http://drupal.org/node/1354#hookimpl
• jqgrid_views_pre_build(): this function does not do anything, so remove it.
• You can ignore the method name errors from the automated review for overriden Views methods.

Review of the 7.x-1.x branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

• jqgrid_callback_update(): why are you running check_plain() on $_POST items if you never print them in this function? Do not filter on input, filter on output only. "the golden rule is to store exactly what the user typed. When a user edits a post they created earlier, the form should contain the same things as it did when they first submitted it. This means that conversions are performed when content is output, not when saved to the database." See http://drupal.org/node/28984
• jqgrid_json(): use drupal_json_decode() instead of json_decode().
• "$search_on = jqgrid_strip($_REQUEST['_search']);": why do you need to strip anything from that? You never print the variable, you only use it in an if statement. I still don't get the purpose of jqgrid_strip(). Same for $filter_on.
• jqgrid_theme(): you don't need to determine the full path to your module here. 'path' defaults to your module directory anyway, so you just need 'theme/theme.inc' for 'file'.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Review of the 7.x-1.x branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

• don't forget to address the automated review, errors are still present apart from the Views integration.
• views-view-jqgrid.tpl.php: why do you need that if it does not add any markup?
• please use more descriptive commit messages, see http://drupal.org/node/52287

Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

add review

Sorry for the delay,
this module quite big, so I only had a raw look on it..

• Please consider using some html tags to make you project page look more structured :) (you should definitely put a screenshot in)
• you got core = 7.x twice in your .info

• Warning: include_once(/home/patrickd/www/drupal-7-test/theme/theme.inc): failed to open stream: No such file or directory in _theme_process_registry() (line 549 of /home/patrickd/www/drupal-7-test/includes/theme.inc).
  Warning: include_once(): Failed opening '/home/patrickd/www/drupal-7-test/theme/theme.inc' for inclusion (include_path='.:/usr/share/php:/usr/share/pear') in _theme_process_registry() (line 549 of /home/patrickd/www/drupal-7-test/includes/theme.inc).

  I get this after every cache clear? (It's gone by disabling your module)

• I created a simple view and get these errors:
  

      Notice: Undefined index: columns in theme_jqgrid() (line 109 of /home/patrickd/www/drupal-7-test/sites/all/modules/1352286-50e0236/theme/theme.inc).
      Notice: Undefined index: default in theme_jqgrid() (line 152 of /home/patrickd/www/drupal-7-test/sites/all/modules/1352286-50e0236/theme/theme.inc).
      Notice: Undefined index: scroll in theme_jqgrid() (line 159 of /home/patrickd/www/drupal-7-test/sites/all/modules/1352286-50e0236/theme/theme.inc).
      Notice: Undefined index: sortable in theme_jqgrid() (line 160 of /home/patrickd/www/drupal-7-test/sites/all/modules/1352286-50e0236/theme/theme.inc).
      Notice: Undefined index: filterToolbar in theme_jqgrid() (line 161 of /home/patrickd/www/drupal-7-test/sites/all/modules/1352286-50e0236/theme/theme.inc).
      Notice: Undefined index: rowNum in theme_jqgrid() (line 167 of /home/patrickd/www/drupal-7-test/sites/all/modules/1352286-50e0236/theme/theme.inc).
      Notice: Undefined index: height in theme_jqgrid() (line 170 of /home/patrickd/www/drupal-7-test/sites/all/modules/1352286-50e0236/theme/theme.inc).
      Notice: Undefined index: scroll in theme_jqgrid() (line 171 of /home/patrickd/www/drupal-7-test/sites/all/modules/1352286-50e0236/theme/theme.inc).
  

• I saved the format settings (in these settings there are lots of checkboxes without any description ?!) and the above errors were gone - and it's working then
• 'view_name' column should have varchar(128) (have a look at views tables itsself)
• for the column containing serialized stuff you should use longblob BINARY type instead of text BIG

This all looks pretty unstable to me, and probably has a hand full of bugs more I could not find.
After all this process is about beeing sure you got the knowledge to develop drupal modules the right way - and I'm sure you got it!
Anyway - you should first create an unstable or alpha release for this and do much more intensive testing before creating a release ;)

Thanks for your contribution and welcome to the community of project contributors on drupal.org! :)

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.