Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Dec 2011 at 09:00 UTC
Updated:
1 Feb 2012 at 19:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
jinlong commentedIt appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:
This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.
Source: http://ventral.org/pareview - PAReview.sh online service
Comment #2
ahwebd commentedThanks for the quick reply,
I was just in the cleaning process after I found http://ventral.org/pareview
When I finish I'll make a new commit.
Comment #3
ahwebd commentedCan you please check now
Comment #4
drupalnetworks commentedComment #5
ahwebd commentedversion removed
Comment #6
patrickd commentedPlease give more detailed information on your project page (some screenshots also would be nice)
Same with your readme, one line is not pretty informative ;-) what about installation? configuration? any Theme-specific thinks a themer should know?
I'm not an expert about themes but this looks pretty good to me, so I'll RTBC this after you made created a nice project page and readme!
Comment #7
ahwebd commentedProject page and README.txt updated,
Comment #8
patrickd commentedI think this is ready to go.
Comment #9
klausiReview of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.
manual review:
There is not really much to review here, so I think your project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 5 functions or 120 lines of code cannot be seriously reviewed. So I have promoted this single project for you and you can get back to us when you have a new project that you want to promote.
Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.
Thanks for your contribution, ahwebd! Welcome to the community of project contributors on drupal.org.
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.
Comment #10
ahwebd commentedThank you!