Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Dec 2011 at 12:49 UTC
Updated:
31 Aug 2012 at 10:21 UTC
The predicabletests module registers minimal tests which are predicable,
i.e. they always or never pass. You know which result to expect.
At first, this module will be used to illustrate articles about running tests on Drupal with drush then with Jenkins.
Here are some other use cases where this module could help:
git clone --branch master benoit.bryon@git.drupal.org:sandbox/benoit.bryon/1363566.git predicabletests
Comments
Comment #1
patrickd commentedSounds quite interesting!
Automated report:
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:
This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.Source: http://ventral.org/pareview - PAReview.sh online service
http://ventral.org/pareview/httpgitdrupalorgsandboxbenoitbryon1363566git
Comment #2
patrickd commentedSwitched back to needs review, so in-depth reviews won't be blocked by coding standart issues.
Comment #3
benoit.bryon commentedImproved coding standards implementation.
http://ventral.org/pareview/httpgitdrupalorgsandboxbenoitbryon1363566git no longer reports errors.
Comment #4
benoit.bryon commentedAlso:
Comment #5
sven.lauer commentedEven though the module is really simple, I agree that there are use cases for it. I wonder though: Why isn't there a failing WebTestCase?
Also, about the name: Running words together is generally frowned upon, though I can't find a place where the naming convention is spelled out. Anyways, how about using "predictable_tests" as the short name instead? And the value of "name" in the info file should be the human-readable name of the module, so something like "Predictable tests" would be nicer.
In general, I think the module is too short to gain "Full project" access for you---I am not an authority on this, but there is not much to review, really. Of course, the module still can be promoted to a full project once it is vetted.
Comment #6
benoit.bryon commentedsven.lauer said:
Comment #7
benoit.bryon commentedsven.lauer said
I couldn't find an usage for a failing WebTestCase. The provided tests classes are enough for my current usage. If you have ideas, let's discuss them as feature requests: I opened http://drupal.org/node/1391090 about this one.
Comment #8
benoit.bryon commentedsven.lauer said:
Understood. I don't mind if I personally don't get full project access right now. What is important to me is that the project can be installed as any "full project" module. As an example, with drush dl predictable_tests.
Don't know if it helps trusting me, but I'm using Drupal as a Makina Corpus' team member. You can review some of our articles at Makina Corpus' blog.
Comment #9
benoit.bryon commentedWorked on the module. See previous comments.
Comment #10
themebrain commentedReview of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Source: http://ventral.org/pareview - PAReview.sh online service
Manual review:
- add translate function for the description for example:
Comment #11
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.