Created a small module for attractive display of ads, called "AdBar".
Screenshot says it all: http://kunden.nicowestermann.de/adbar/adbar-screenshot.jpg
Project page: http://drupal.org/sandbox/webnotwar/1223604
It is very configurable. More features possible.

I'm new to git, an applying for permission to create full projects. There are some more projects i like to commit.

Comments

patrickd’s picture

There are many other very comfortable and configurable ad-modules, maybe you should consider helping them develop a 7.x version rather than create yetAnotherAdverisementModule. Maybe you point out why your module is that different to others to justify that it has to be a new one?

You forgot to authenticate yourself to git
git config user.email "your@email.org"

The ID tags are deprecated. GIT doesn't need them.
// $Id$
Just remove them.

Your module is a little rarely commented, imho the best documentation is a well commented code ;-)

There are some coding standart violations you can easily detect by the coder module
http://drupal.org/coding-standards
http://drupal.org/project/coder

I was never into d6 so I can't give you a code review in detail

Your not living too far from munich maybe we meet us at the drupal community and talk about your other projects :)

patrickd’s picture

Status: Needs review » Needs work
webnotwar’s picture

Status: Needs work » Needs review

I cleaned the code to match the coding standards and added some more comments.

Also, i did a long search to find a module whitch already have this functionality - without any result. It differs from the classical overlay ads because there is no need to klick the ad away to use the page. This is a lot more compfortable for the user.

klausi’s picture

Status: Needs review » Needs work

* don't use "version" in your info file, this is added by drupal.org packaging automatically for releases. see http://drupal.org/node/542202
* @file doc block is missing in the module file, see http://drupal.org/node/1354#files
* doc block for hook_block() implementation is missing, see http://drupal.org/node/1354#hookimpl
* "// display only if there is some content" comments should be on a new line, start capitalized and end with a ".". See http://drupal.org/node/1354#inline
* "switch ($delta)": why? you only have one case, so an if statement should do it.
* a "break;" is not needed after a return statement.

misc’s picture

The applicant has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

misc’s picture

Status: Needs work » Closed (won't fix)

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact