Appointment

Hi. Since moving to git prospective developers now can create sandbox projects. You will need to set up a sandbox and provide a link to your sandbox here.

Please see http://drupal.org/node/1011698 for more information. Your application will be postponed until these steps are complete. Once you can provide a link to your sandbox project please return here and do so and set the application back to "Needs review".

Hi,

Please review the Drupal coding and commenting standards at http://drupal.org/coding-standards

All of your functions and files need to be documented properly.

Indentation needs to be fixed throughout the module.

Pease run your module through the Coder module on minor (most).

Did you intend to close this? If you have completed the fixes but still would like your application to continue review it should be set to "Needs review" so it can be seen in the queue and reviewers know to review it.

Yeah, I just realized after posting on your other issue that there were two open. You certainly do not want to just start over or it is very likely that your application will only take longer, so I've closed the other application. If you look at the queue you'll see that applications take over a month in most cases, and many applications may sit for weeks without response. But thats not to say we aren't working on it. If you set your application to needs review and no one responds for a period of time you can consult the guidelines for project application priorities and elevate the priority of your own application if necessary. The priority guidelines demonstrate that there are often time lapses in the review process, and a look at the project application queue shows that there are several applications with a critical priority currently.

It has only been nine days since the application status was set to needs review (I know it sounds bad to say only, but we have to prioritize applications in all fairness). I'll assign your application to myself and try to get back to the review shortly. If I haven't responded in a few days you are welcome to elevate the priority to major according to guidelines.

Why not use system_settings_form() for appointment_admin_settings form? It will use form elements keys to set the variables for you without needing a submit function.

Good use of forms and theme functions other than that.

Variables set by your module need to be deleted in hook_uninstall().

Arrays should be formatted with the opening parenthesis right after array (in hook_schema()): array( Coding standards are not necessarily a requirement of the process, but they help facilitate collaboration and help reviewers.

$query = "SELECT count(*) as total FROM {appointment} WHERE email = '". $email ."'";
There's no reason you can't use placeholders and db_query here.

$result = db_query("SELECT COUNT(*) as total from {appointment} WHERE email = '%s'", $email);

And here: INNER JOIN {appointment_folio} AS ccff ON cc.cfid = ccff.cfid WHERE cc.ccid = $ccid";

And several other places. That's a security risk and needs to be fixed.

Also, preventing module duplication is one of the primary goals of application reviews, and according to another thread I found there are a few options for modules for creating appointments already.

There's a couple of options available in the modules area that I can think of: merci, booking_timeslots, volunteer_timeslots, and publicbookings.

How does your module differ from these options?

Suggestions

appointment_schema doesn't have enough spaces before the "$schema['" - each line should be 2 spaces indented and then lines under that should be indented again, etc. You got this right elsewhere, probably just an oversight.

There is some Spanish in the user interface like Guardar.

Instead of _validate_email you can use valid_email_address.

It would be great if you documented on the project page what makes this different from the other modules.

Required changes

The url http://example.com/appointment/confirmation/1 is vulnerable to XSS.

I suggest something like:

  while ($row = db_fetch_object($result)) {
    $appointment = $row;
    $appointment->name = check_plain($row->name);
    $appointment->last_name = check_plain($row->last_name);
  }

If you haven't already, I suggest reading http://drupal.org/writing-secure-code

Thanks for your contribution and your patience!

The applicant has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact