Name: Realworks Integration

Description: This module uses cron to synchronise with the Dutch Realworks real estate service, xml is fetched once a day and included images are fetched only when needed (new or updated). The xml is parsed on the fly to provide Realworks real estate entries on your site, there are several templates to provide close integration with your site's theming.

At the moment not all fields from the xml are used, it's a very complex scheme and to make matters worse: Realworks explicitly states they can change it at any time as they please without prior notice.

Sandbox link: http://drupal.org/sandbox/cinnamon/1151546

CommentFileSizeAuthor
#11 realworks.patch2.32 KBcinnamon
#9 realworks.module.patch821 bytescinnamon

Comments

cinnamon’s picture

Status: Active » Needs review
ralt’s picture

Status: Active » Needs review

Hi,

Do you have a demo website?

Also, don't you think you can achieve the same thing with Feeds?

ralt’s picture

Component: new project application » module
Status: Needs review » Active
jordojuice’s picture

Title: Realworks Integration module application » Realworks Integration
Status: Needs review » Active
Issue tags: +pdx-code-review

Updating title and tags. Why active? The normal workflow is to switch between needs work and needs review (unless a module is postponed or something).

ralt’s picture

When waiting for OP info, isn't active the right status?

jordojuice’s picture

Status: Active » Needs work

Not according to common practice and documentation. Workflow documentation for project applications can be found at http://drupal.org/node/532400. It can be confusing that it is a bit different than most other queues. We normally change the status to a more appropriate status when there's an "Active" issue in the queue, as well as any applications with priorities other than "normal". Some of these items may change in the near future, but for now the workflow remains. By the way, you are doing a fantastic job! You seem to be getting a ton done, which is badly needed in this queue! (not just saying that either)

joachim’s picture

define('REALWORKS_XML_URL2', variable_get('realworks_uri', 'http://xml-publish.realworks.nl/servlets/ogexport?koppeling=WEBSITE&user=1234567&password=76543216&og=WONEN'));

Weird. Either use a variable or a constant, not both.

define('REALWORKS_XML_FILE2', dirname(dirname(dirname(dirname(dirname(__FILE__))))) . '/default/files/woningaanbod2.xml');

Weirder. WTF?

This needs a lot of work, though bear in mind Ralt's comment above on Feeds.

cinnamon’s picture

Demo would be http://www.mennes.nl, all the property listings there are fetched, processed and displayed through this module. Perhaps feeds would get me half the way but I highly doubt it: we need to fetch the xml exactly once a day not more (penalty if the client exceeds this) and images need to be cached locally (same penalty there). Also the xml is very complex, one could argue they did that on purpose ;)

All and all this is very very specific to the Dutch Realworks realestate service, but perhaps it could be of use to the Dutch drupal community.

About the weird and weider parts: I started out with a piece of code my former college made and that bypassed Drupal completely ... this must be some of very little of that code left, could be done better agreed.

cinnamon’s picture

StatusFileSize
new821 bytes

Got rid of the WTF part ;) Is it really mandatory to get rid of the constants? I understand it isn't pretty but safes me from quite at lot of typing.

The real module is in production and just works(tm), consider this an alpha release of a more generic module that might be of use to others working in the dutch realestate business with Drupal.

joachim’s picture

> Is it really mandatory to get rid of the constants?

Defining a constant to be the value of a variable just seems very weird. Constants should be constant.

cinnamon’s picture

StatusFileSize
new2.32 KB

You're right. Anyway I was making too much of a problem, it wasn't that much work.

Please let me know if there are more problems, as said the module is in use and just works for our client.

klausi’s picture

Status: Needs work » Closed (won't fix)

No activity in several months. Reopen and set the status to "needs review" if you are still pursuing this application.