Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Apr 2011 at 15:03 UTC
Updated:
26 May 2011 at 03:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
tsi commentedAnd here's a link to the sandbox project - http://drupal.org/sandbox/tsi/1114098
Comment #2
tsi commentedHi guys,
any news on that ?
Comment #3
sreynen commentedChanging the status to "needs review" is an important part of the instructions, because reviewers tend to look only at issues in that status.
Comment #4
tsi commentedmy bad, thanks.
Comment #5
dcmouyard commentedThis theme follows the coding standards pretty well, but I do have two minor nitpicks:
The major issue, however, is that this theme is not accessible due to color contrast. I created an issue at #1140046: All text output should should meet minimum contrast guidelines
Use the Style Guide module to preview the most common Drupal output in this theme. There are several occurances of light text on a white background and black text on a dark background.
Comment #6
tsi commentedThank's for the review,
I've answered about the accessibility issue on #1140046: All text output should should meet minimum contrast guidelines.
Regarding CSS properties order and shorthands, I've modified my style sheets, patch with all changes attached.
Commit - http://drupalcode.org/sandbox/tsi/1114098.git/commit/2782112
Comment #7
sreynen commentedI'm marking this as reviewed. I haven't found any new issues and the only issues still open has been partially resolved while tsi awaits more details. It seems like something that may take a while to work out, and not something that needs to keep this from becoming a full project.
Comment #8
gregglesThanks for your contribution, tsi! Welcome to the community of contributors on drupal.org.
I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Comment #9
tsi commentedThanks
Comment #10
sarah_p commented