CVS edit link for jhubley

Hello,

I'm interested in getting a CVS account because I want to add themes for the Drupal community to use, including the one I'm presenting here for review, Graze. Particularly I'm interested in making designs that are in tune with current web design trends, making available some themes that are lightweight, and helping build the Drupal theme directory to make the Drupal project more attractive to people that might otherwise choose WordPress. There aren't yet many themes available for D7 and Graze will be one more for people to use for blogs or general websites.

Graze is a css-based, tableless theme in shades of gray with a subtle textured background. One or two sidebars can be added to the main content area. An optional region exists between the main content container and the footer. The theme includes a css sticky footer, and makes use of Paul Irish's 'bulletproof' @font-face implementation. I've tested the theme in all major browsers (Firefox, Chrome, Safari, Opera, IE) for cross-compatibility. I've used CSS3 styling (including rgba background transparencies), but the theme degrades gracefully and includes fallbacks for older browsers. A demo of the theme can be seen at graze.jillhubley.com

Thanks very much for taking the time to review my CVS application.

Sincerely,
Jill Hubley

CommentFileSizeAuthor
#7 screenshot.png844.65 KBjhubley
#3 graze.tgz995.75 KBjhubley
#3 screenshot.png512.37 KBjhubley
#1 screenshot.png512.37 KBjhubley
#1 graze.tgz999.32 KBjhubley

Comments

jhubley’s picture

jhubley commented
Component: Miscellaneous » miscellaneous
StatusFileSize
new graze.tgz999.32 KB
new screenshot.png512.37 KB
jhubley’s picture

jhubley commented
Status: Postponed (maintainer needs more info) » Needs review
jhubley’s picture

jhubley commented
Component: miscellaneous » new project application
StatusFileSize
new screenshot.png512.37 KB
new graze.tgz995.75 KB

A couple of updates:

  • I removed LICENSE.txt because I saw that requested on other CVS applications. I didn't realize before that it gets added when a project is committed to the Drupal.org CVS repository.
  • I also removed a couple of unnecessary image files (which were in there from an earlier working version.)

Additionally, here are the features of my theme in list format. I hope this makes it easier to review/might speed along the process?

Graze theme

Features


  • A CSS-based, table-less theme in shades of gray with a subtle textured background
  • One or two sidebars can be added to the main content area
  • An optional region exists between the main content area and the footer
  • Includes a CSS sticky footer
  • Uses Paul Irish's bulletproof @font-face implementation
  • Incorporates CSS3 styles such as border-radius, rgba opacity, text-shadow
  • Includes fallbacks for older browsers (e.g. png fix for background rgba opacity)
  • Tested for compatibility in Firefox, Chrome, Safari, Opera and IE
arianek’s picture

arianek commented
Status: Needs review » Postponed

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
jhubley’s picture

jhubley commented
Project: Drupal.org CVS applications » Drupal.org security advisory coverage applications
Status: Postponed » Needs review

I have put up my theme as a sandbox project in git.

It's now ready for review:
http://drupal.org/sandbox/jhubley/1087416

sreynen’s picture

sreynen commented
Status: Needs review » Needs work

Hi jhubley,

The theme looks good. I only see one major problem: The embedded fonts appear to be from a 3rd party, which is not allowed on Drupal.org. This is a problem beyond getting full project status; it shouldn't even be in your sandbox project. If you look at the "Git access" section of your profile, you'll see you specifically agreed not to upload 3rd party resources before you got Git access. Also, these files violate the GPL requirement for Drupal.org hosted resources.

As alternatives, you can either point users to where they can download these fonts, or point to the fonts on a hosted server somewhere. It's just not allowed to host them on Drupal.org.

jhubley’s picture

jhubley commented
Status: Needs work » Needs review
StatusFileSize
new screenshot.png844.65 KB

Hi sreynen,

Thanks for alerting me to the problem with the 3rd party fonts. I've removed the files from my sandbox project and will make sure to adhere to the policy going forward.

Rather than host the fonts elsewhere or provide instructions on downloading the fonts from elsewhere, I decided to switch to common fonts (Geneva, Verdana).

Thanks again.

sreynen’s picture

sreynen commented
Status: Needs review » Reviewed & tested by the community

Great, I don't see any other problems.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Looks great to me too! As such, I'm approving this Project application. jhubley, enjoy promoting your sandbox to a full theme project! Be sure to subscribe to your theme's issue queue to always be alerted to issues that other users file. Now that you have the ability to create full projects without review, make sure to take a little bit of time before each project to check to see if you can coordinate with an existing effort, or maybe put code in a sandbox first and ask for peer review. It is a pleasure to have you has a new, official contributor to Drupal.org!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.