I updated the directions in the database today. I'm going to attach those changes for review ... the patch is slightly different than what I've updated in the db ... I want the Updated notice to point to the CHANGELOG.txt, but I can't really do that until the CHANGELOG.txt is actually deployed.

CommentFileSizeAuthor
#4 1104526-2-default_direction_updates.patch13.18 KBeliza411
#1 1104526-default_directions_update.patch12.16 KBeliza411

Comments

eliza411’s picture

eliza411 commented
StatusFileSize
new 1104526-default_directions_update.patch12.16 KB

Attaching the patch file.

halstead’s picture

halstead commented
Status: Active » Needs work 
+++ b/CHANGELOG.txt
@@ -1,10 +1,18 @@
+- Default direction updates    ¶

and

+++ b/CHANGELOG.txt
@@ -1,10 +1,18 @@
+    ¶

Have extra spaces.

+++ b/project_git_instructions.module
@@ -362,6 +362,11 @@ function project_git_instructions_project_promote_sandbox($project) {
+v class="meta">

It looks like something is missing here. It looks like the line above v class="meta"> is missing.

Powered by Dreditor.

eliza411’s picture

eliza411 commented
Status: Needs work » Active

Fixes:
#1080860: Simplify detail on commit messages
#1092226: Fix git tab instructions to suggest using "git diff" instead of "git format-patch"
#1104302: Add directions for applying patches and reverting changes

eliza411’s picture

eliza411 commented
StatusFileSize
new 1104526-2-default_direction_updates.patch13.18 KB

I also updated the date and put the meta block on the sandboxes, which I had forgotten.

halstead’s picture

halstead commented
Status: Active » Reviewed & tested by the community

Ready to commit.

eliza411’s picture

eliza411 commented
Title: Commit updates » Commit updates made to default instructions
Issue tags: +needs drupal.org deployment

Tagging for deployment

eliza411’s picture

eliza411 commented
Status: Reviewed & tested by the community » Fixed

Committed http://drupalcode.org/project/project_git_instructions.git/commit/1d9d5d9

sdboyer’s picture

sdboyer commented
Issue tags: -needs drupal.org deployment

deployed

helmo’s picture

helmo commented

Congrats on your first commit.

One remark, the author/commiter is now recorded as: Testing Person

You might wanna review: http://drupal.org/node/1022156#identify-global

eliza411’s picture

eliza411 commented

Yeah, I noticed that. :( I've got myself all set up proper now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 1d9d5d9 on 6.x-1.x, 7.x-1.x-dev: 
    Issue #1104526 by eliza411: Changed default instruction text