I am see an enhancement when using multiple webforms where the forms might be using the same files. I have 9 webforms on my site, 4 of which share a few files to be protected. It seems that when you add a file to the webform and protect it it goes to the private folder. So if you have 2 webforms with the same file name attached, it goes into the private folder only once. If you delete the file from one form, it makes the file listed as missing on the other form. Also it seems that when the user submits a form, that a session ID is assigned to the file for that user. If a user then submits a different form with the same file name, one of the users gets an access denied for that particular file.
I have subverted this issue by naming the files different for each webform even though they are the exact file. I would suggest either a way to get subfolders within the private folder for each webform, so each web form can have it's own files. Hopefully this would fix both the access denied issue and the missing file issue if the file is deleted from a different webform.
Any testing you need to help with this I would be willing to do.
Comments
Comment #1
berliner commentedThat is actually a bug in the private upload module. Thank you very much for pointing this out, I wasn't aware of this. It seems like a critical bug to me, obviously already known and presumably fixed (http://drupal.org/node/277692, http://drupal.org/node/645446) though I could easily reproduce the behaviour.
Webform protected downloads should not have Problems with multiple files with the same base name, since the references between file and webform are made using the database internal file id that is different for each uploaded file, independent of the files name.