Currently incldued 1.23.1 Twig has problem with whitespace on PHP 7.4: https://github.com/twigphp/Twig/issues/3248
Update Twig to latest that still supports PHP 5: 1.42.5.
That requires polyfill-cytpe, so used the one that still supports PHP 5 too: 1.19
Also update yaml while we are at it to the last one that supported PHP 5: 3.4.41
Since there are more cross-dependencies now, let's also include a full composer lib build with autoload and all, that helps not to have a custom loader that did not work anymore with these many dependencies.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3298467-noop.patch | 285 bytes | gábor hojtsy |
| #3 | 3298467.patch | 1.81 MB | gábor hojtsy |
| #2 | 3298467.patch | 1.81 MB | gábor hojtsy |
Comments
Comment #2
gábor hojtsyComment #3
gábor hojtsyRerolled as binary but removed the DS Store.
Comment #4
gábor hojtsyHere is a noop patch for comparison, should theoretically fail on PHP 7.4.
Comment #5
gábor hojtsyOk the fail on PHP 7.4 nicely demonstrated the Twig difference without updating Twig. The updated Twig looks good though.
Also no need to port to the Drupal 8/9 version of the project as that uses the Drupal included Twig version, and as long as the same tests pass there its good. (This patch does not include test changes at all).